Updating docs and fixing command #2181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trying to fix build fixing script Apply level from configuration updating lgtm version fixing lgtm version updating version adding binlog rollback change
eddynaka
force-pushed
the
users/ednakamu/multitool-enhancements
branch
from
f3bf90d
to
6250141
Compare
eddynaka
commented
Dec 12, 2020
|
|
||
| - task: PublishBuildArtifacts@1 | ||
| inputs: | ||
| pathToPublish: 'msbuild.binlog' |
There was a problem hiding this comment.
msbuild.binlog [](start = 22, length = 14)
Our build is failing some times. This will help us investigate
eddynaka
commented
Dec 12, 2020
| @@ -93,7 +93,7 @@ function Invoke-DotNetBuild($solutionFileRelativePath) { | |||
| Write-Information "Building $solutionFileRelativePath..." | |||
|
|
|||
| $solutionFilePath = Join-Path $SourceRoot $solutionFileRelativePath | |||
| & dotnet build $solutionFilePath --configuration $Configuration -v $BuildVerbosity --no-incremental | |||
| & dotnet build $solutionFilePath --configuration $Configuration --verbosity $BuildVerbosity --no-incremental -bl | |||
There was a problem hiding this comment.
-bl [](start = 112, length = 4)
add binlog parameter
eddynaka
commented
Dec 12, 2020
| @@ -542,6 +542,9 @@ private SupportedPlatform GetCurrentRunningOS() | |||
| DefaultDriverOptions.CreateRuleSpecificOption(skimmer, DefaultDriverOptions.RuleEnabled); | |||
|
|
|||
| RuleEnabledState ruleEnabled = rootContext.Policy.GetProperty(ruleEnabledProperty); | |||
| FailureLevel failureLevel = (ruleEnabled == RuleEnabledState.Default || ruleEnabled == RuleEnabledState.Disabled) | |||
There was a problem hiding this comment.
failureLevel [](start = 29, length = 12)
generate failureLevel from the file. With that, we can replace our default value
There was a problem hiding this comment.
ok! but we need more unit tests here, clearly. :) maybe yong can help?
In reply to: 541631128 [](ancestors = 541631128)
eddynaka
commented
Dec 12, 2020
|
|
||
| using Microsoft.CodeAnalysis.Sarif.Driver; | ||
|
|
||
| namespace Microsoft.CodeAnalysis.Sarif.Multitool | ||
| { | ||
| public class ExportValidationConfigurationCommand : ExportConfigurationCommandBase | ||
| { | ||
| public override IEnumerable<Assembly> DefaultPlugInAssemblies => new Assembly[] { |
There was a problem hiding this comment.
DefaultPlugInAssemblies [](start = 46, length = 23)
fixing a null reference
…b.com/microsoft/sarif-sdk into users/ednakamu/multitool-enhancements
…b.com/microsoft/sarif-sdk into users/ednakamu/multitool-enhancements
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes: