MultithreadedAnalysis with file hashing and caching #2388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removing hashes computation, marking hash as complete Adding tests, updating FileSystem Fixing condition to create hash
eddynaka
commented
Sep 24, 2021
| @@ -384,11 +411,12 @@ private async Task<bool> FindFilesAsync(TOptions options, TContext rootContext) | |||
| filePath: file) | |||
| ); | |||
|
|
|||
| await _fileEnumerationChannel.Writer.WriteAsync(_fileContextsCount++); | |||
| await _hashChannel.Writer.WriteAsync(_fileContextsCount++); | |||
suvamM
reviewed
Sep 30, 2021
| @@ -0,0 +1,4 @@ | |||
| { | |||
| "AssembliesPath":"..\\..\\bld\\bin\\AnyCPU_Debug\\Test.UnitTests.Sarif.Driver\\netcoreapp3.1", | |||
There was a problem hiding this comment.
@eddynaka This path is incorrect for releases. #Closed
shaopeng-gh
reviewed
Oct 7, 2021
| # Visual Studio Version 16 | ||
| VisualStudioVersion = 16.0.29709.97 | ||
| # Visual Studio Version 17 | ||
| VisualStudioVersion = 17.0.31728.443 |
There was a problem hiding this comment.
Question, this is version 2022 right, do we want to upgrade, should we revert this change? #Closed
There was a problem hiding this comment.
the other file NuGet.Config maybe also auto changed by VS 2022. my only question is if solution still works for VS 2019 if so we can check it in.
There was a problem hiding this comment.
it does not matter if u are using VS2019 or VS2022.
The nuget change is just to show when we open the sln.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change will enable Caching of the results when
--insert Hashesis enabled.Current design:
FileEnumerator adds to HashChannel
HashAsync reads from HashChannel and write in AnalysisChannel
AnalysisAsync starts processing.