Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing suppression logic #2395

Merged
merged 4 commits into from
Oct 12, 2021
Merged

Fixing suppression logic #2395

merged 4 commits into from
Oct 12, 2021

Conversation

eddynaka
Copy link
Collaborator

No description provided.

yongyan-gh
yongyan-gh reviewed Oct 12, 2021
View reviewed changes
src/Test.UnitTests.Sarif/Core/ResultTests.cs Outdated
{
Suppressions = new List<Suppression>()
};
result.TryIsSuppressed(out bool _).Should().BeTrue();
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

_

can also verify isSuppressed should be false, to cover the scenario when empty suppression the result should be not suppressed.

yongyan-gh
yongyan-gh approved these changes Oct 12, 2021
View reviewed changes
Copy link
Collaborator

@yongyan-gh yongyan-gh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Bpendragon
Bpendragon approved these changes Oct 12, 2021
View reviewed changes
Copy link

@Bpendragon Bpendragon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@eddynaka eddynaka merged commit f63c92f into main Oct 12, 2021
@eddynaka eddynaka deleted the users/ednakamu/fixing-suppression-logic branch October 12, 2021 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bpendragon Bpendragon Bpendragon approved these changes

@yongyan-gh yongyan-gh yongyan-gh approved these changes

@michaelcfanning michaelcfanning Awaiting requested review from michaelcfanning michaelcfanning is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eddynaka @Bpendragon @yongyan-gh