Fix error in Linux ERR999.UnhandledEngineException : System.InvalidOperationException: This operation is not supported for a relative URI.
#2664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shaopeng-gh
requested review from
michaelcfanning,
EasyRhinoMSFT,
marmegh and
cfaucon
as code owners
shaopeng-gh
commented
May 4, 2023
ReleaseHistory.md
Outdated
| @@ -14,6 +14,7 @@ | |||
| * BRK: Remove unused `quiet` parameter from `SarifLogger`. [#2639]https://github.com/microsoft/sarif-sdk/pull/2639 | |||
| * BRK: Remove `ComputeHashData` and `AnalysisTargetToHashDataMap` properties from `SarifLogger` (in preference of new `fileRegionsCache` parameter. [#2639](https://github.com/microsoft/sarif-sdk/pull/2639) | |||
| * BRK: Eliminate proactive hashing of artifacts in `SarifLogger` constructor when `OptionallyEmittedData.Hashes` is specified. [#2639](https://github.com/microsoft/sarif-sdk/pull/2639) | |||
| * BUG: Fixed `ERR999.UnhandledEngineException`: `System.InvalidOperationException`: "This operation is not supported for a relative URI" when running in Linux with files skipped due to zero byte size. [#2664](https://github.com/microsoft/sarif-sdk/pull/2664) | |||
There was a problem hiding this comment.
Put the whole thing from ERR999 to relative URI inside backticks,
suvamM
approved these changes
May 4, 2023
ReleaseHistory.md
Outdated
| @@ -14,6 +14,7 @@ | |||
| * BRK: Remove unused `quiet` parameter from `SarifLogger`. [#2639]https://github.com/microsoft/sarif-sdk/pull/2639 | |||
| * BRK: Remove `ComputeHashData` and `AnalysisTargetToHashDataMap` properties from `SarifLogger` (in preference of new `fileRegionsCache` parameter. [#2639](https://github.com/microsoft/sarif-sdk/pull/2639) | |||
| * BRK: Eliminate proactive hashing of artifacts in `SarifLogger` constructor when `OptionallyEmittedData.Hashes` is specified. [#2639](https://github.com/microsoft/sarif-sdk/pull/2639) | |||
| * BUG: Fixed `ERR999.UnhandledEngineException`: `System.InvalidOperationException`: "This operation is not supported for a relative URI" when running in Linux with files skipped due to zero byte size. [#2664](https://github.com/microsoft/sarif-sdk/pull/2664) | |||
There was a problem hiding this comment.
Put the whole thing from ERR999 to relative URI inside backticks,
…com/microsoft/sarif-sdk into users/shaopeng-gh/fixlinuxpathissue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test:
have added the test in BinSkim after this is merged in and sub-module update,
the failing test that repro the issue (microsoft/binskim#884) will pass see below:
Reason:
Below code will output false in Linux, means not absolute Uri.
But I think it is wrong, I don't know if it is .NET bug or not. The url should be a absolute uri.
The place fix is made, if you look at the code above, it is always a Absolute uri before reaching the line. So we don't leave .NET to do the guessing, we just create a Absolute uri.