HdfConverter: Set precision and tags #2712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
candrews
requested review from
michaelcfanning,
EasyRhinoMSFT,
marmegh and
cfaucon
as code owners
|
@michaelcfanning, With this change, the resulting SARIF results in GitHub seem to look good. I uploaded ValidResults.sarif to see what it looks like: https://github.com/candrews/sarif-test/security/code-scanning |
|
Update release notes? Otherwise looks good. |
GitHub recommends that precision be set. Other tools, such as Trivy, set precision="very-high" when there's no available data to determine otherwise, so that's what's done here too. tags must include "security" for GitHub to process the security-severity and consider the results to be a security finding. See: https://docs.github.com/en/code-security/code-scanning/integrating-with-code-scanning/sarif-support-for-code-scanning#reportingdescriptor-object Signed-off-by: Craig Andrews <candrews@integralblue.com>
candrews
force-pushed
the
precision-and-tags
branch
from
1267971
to
c5c148a
Compare
Updated the release notes |
|
Alright! You ready for me to burn a release for you? |
I am! :-D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub recommends that precision be set. Other tools, such as Trivy, set precision="very-high" when there's no available data to determine otherwise, so that's what's done here too.
tags must include "security" for GitHub to process the security-severity and consider the results to be a security finding.
See: https://docs.github.com/en/code-security/code-scanning/integrating-with-code-scanning/sarif-support-for-code-scanning#reportingdescriptor-object