Pinecone memory connector #1065
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### Motivation and Context <!-- Thank you for your contribution to the semantic-kernel repo! Please help reviewers and future users, providing the following information: 1. Why is this change required? 2. What problem does it solve? 3. What scenario does it contribute to? 4. If it fixes an open issue, please link to the issue here. --> ### Description <!-- Describe your changes, the overall approach, the underlying design. These notes will help understanding how your code works. Thanks! --> ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [x] The code builds clean without any errors or warnings - [x] The PR follows SK Contribution Guidelines (https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) - [x] The code follows the .NET coding conventions (https://learn.microsoft.com/dotnet/csharp/fundamentals/coding-style/coding-conventions) verified with `dotnet format` - [x] All unit tests pass, and I have added new tests where possible - [x] I didn't break anyone 😄 --------- Co-authored-by: tech <tech@chancetheapp.com> Co-authored-by: Devis Lucato <dluc@users.noreply.github.com> Co-authored-by: Dmytro Struk <13853051+dmytrostruk@users.noreply.github.com> Co-authored-by: Adrian Bonar <56417140+adrianwyatt@users.noreply.github.com> Co-authored-by: Shawn Callegari <36091529+shawncal@users.noreply.github.com> Co-authored-by: Abby Harrison <54643756+awharrison-28@users.noreply.github.com>
github-actions
bot
added
.NET
dmytrostruk
added
PR: ready to merge
|
@dmytrostruk I believe the Pinecone example from the Kernel-Syntax-Examples wasn't added to the Program.cs file |
@shawncal Should we add Pinecone example to KernelSyntaxExamples Program.cs? I think it was added in original PR. |
Yes, absolutely! Must have been a bad merge (that file sees a lot of conflicts, growth). |
Added back. Good catch! |
shawncal
approved these changes
May 18, 2023
shawncal
added a commit
to johnoliver/semantic-kernel
that referenced
this pull request
May 19, 2023
Pinecone vector database implementation Original PR: microsoft#770 --------- Co-authored-by: Kevdome3000 <kbassjr@gmail.com> Co-authored-by: tech <tech@chancetheapp.com> Co-authored-by: Shawn Callegari <36091529+shawncal@users.noreply.github.com> Co-authored-by: Abby Harrison <54643756+awharrison-28@users.noreply.github.com>
johnoliver
pushed a commit
to johnoliver/semantic-kernel
that referenced
this pull request
Jun 5, 2024
Pinecone vector database implementation Original PR: microsoft#770 --------- Co-authored-by: Kevdome3000 <kbassjr@gmail.com> Co-authored-by: tech <tech@chancetheapp.com> Co-authored-by: Shawn Callegari <36091529+shawncal@users.noreply.github.com> Co-authored-by: Abby Harrison <54643756+awharrison-28@users.noreply.github.com>
johnoliver
pushed a commit
to johnoliver/semantic-kernel
that referenced
this pull request
Jun 5, 2024
Pinecone vector database implementation Original PR: microsoft#770 --------- Co-authored-by: Kevdome3000 <kbassjr@gmail.com> Co-authored-by: tech <tech@chancetheapp.com> Co-authored-by: Shawn Callegari <36091529+shawncal@users.noreply.github.com> Co-authored-by: Abby Harrison <54643756+awharrison-28@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Pinecone vector database implementation: https://docs.pinecone.io/docs/overview.
Original PR: #770
Description
Implementation logic and structure is similar to already existing Qdrant connector.
Contribution Checklist
dotnet format