Initial proposal for Java Kernel #1081
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
alexchaomander
requested review from
dluc,
shawncal,
markwallace-microsoft and
craigomatic
commit f76c7b6 Author: John Oliver <1615532+johnoliver@users.noreply.github.com> Date: Thu May 11 14:07:38 2023 +0100 Reorganize java integration tests commit 3b4abc1 Merge: 60538d3 49def19 Author: John Oliver <1615532+johnoliver@users.noreply.github.com> Date: Thu May 11 12:12:59 2023 +0100 Merge pull request #1 from milderhc/samples Add samples module commit 49def19 Author: John Oliver <1615532+johnoliver@users.noreply.github.com> Date: Thu May 11 11:13:35 2023 +0100 Rename CompletionSkFunction.java to CompletionSKFunction.java commit cb11219 Author: Milder Hernandez Cagua <milderhc@microsoft.com> Date: Thu May 11 03:03:52 2023 -0700 Comment Planner examples as it comes from core commit 7edccc5 Author: Milder Hernandez Cagua <milderhc@microsoft.com> Date: Thu May 11 02:45:21 2023 -0700 Add samples module commit 60538d3 Author: John Oliver <1615532+johnoliver@users.noreply.github.com> Date: Wed May 10 23:03:45 2023 +0100 Update java-build.yml commit b7f7238 Author: John Oliver <1615532+johnoliver@users.noreply.github.com> Date: Wed May 10 22:30:48 2023 +0100 Initial Java Implementation Co-authored-by: Milder Hernandez Cagua <milderhc@microsoft.com> Co-authored-by: David Grieve <dsgrieve@yahoo.com> Co-authored-by: Bruno Borges <brborges@microsoft.com>
add pipeline support
* Add EmbeddingVector and its operations * Fix build and use List * Fix build * Fix
Fixes from code review
I would like to suggest to use the current Java language specification codes.
johnoliver
force-pushed
the
merge-upstream-4
branch
from
4110707
to
59d4393
Compare
github-actions
bot
added
.NET
### Motivation and Context READMEs needed updates from recent changes to configuration schemas. ### Description - Updated to AIService secrets section - Fixed erroneous "https" when referring to localhost:3000 - Minor grammar typos
The skillParentDirectory local used to find the SummarizeSkill in the graph-api-skills sample had one too few levels of directory navigation, resulting in a DirectoryNotFoundException. Initialize variable using RepoFiles.SampleSkillsPath from kernel-syntax-examples project. Reference kernel-syntax-examples project. Make RepoFiles class and SampleSkillsPath method public in kernel-syntax-examples. Add namespace to graph-api-skills/Program.cs to avoid type collision with Program class in kernel-syntax-examples project. Co-authored-by: Adrian Bonar <56417140+adrianwyatt@users.noreply.github.com>
Fixing ci break due to change in <Version> tag format
…ft#1094) ### Motivation and Context Although the source bicep file to deploy SK to Azure was updated to the latest appsettings.json format, the ARM templates it generates were not. The "Deploy to Azure" buttons use the ARM templates and currently deploy broken services. ### Description Generated ARM json files with the following commands: az bicep build -f sk-new.bicep az bicep build -f sk-existing-azureopenai.bicep az bicep build -f sk-existing-openai.bicep ### Contribution Checklist - [ ] The code builds clean without any errors or warnings - [ ] The PR follows SK Contribution Guidelines (https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) - [ ] The code follows the .NET coding conventions (https://learn.microsoft.com/dotnet/csharp/fundamentals/coding-style/coding-conventions) verified with `dotnet format` - [ ] All unit tests pass, and I have added new tests where possible - [ ] I didn't break anyone 😄
### Motivation and Context Please help reviewers and future users, providing the following information: 1. Why is this change required? Merge latest commits from main 2. What problem does it solve? experimental-java is 20 commits behind main 3. What scenario does it contribute to? Java port ### Description Merge latest changes from main to experimental-java ### Contribution Checklist - [x] The code builds clean without any errors or warnings - [x] The PR follows SK Contribution Guidelines (https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) - [x] The code follows the .NET coding conventions (https://learn.microsoft.com/dotnet/csharp/fundamentals/coding-style/coding-conventions) verified with `dotnet format` - [x] All unit tests pass, and I have added new tests where possible - [x] I didn't break anyone 😄 --------- Co-authored-by: Teresa Hoang <125500434+teresaqhoang@users.noreply.github.com> Co-authored-by: Gil LaHaye <gillahaye@microsoft.com> Co-authored-by: Craig Presti <146438+craigomatic@users.noreply.github.com> Co-authored-by: adityachallapally <avasanthc@gmail.com> Co-authored-by: Devis Lucato <dluc@users.noreply.github.com> Co-authored-by: Gina Triolo <51341242+gitri-ms@users.noreply.github.com> Co-authored-by: Adrian Bonar <56417140+adrianwyatt@users.noreply.github.com> Co-authored-by: Gudge <mgudgin@microsoft.com> Co-authored-by: Shawn Callegari <36091529+shawncal@users.noreply.github.com> Co-authored-by: Roger Barreto <19890735+RogerBarreto@users.noreply.github.com> Co-authored-by: Stephen Toub <stoub@microsoft.com> Co-authored-by: Jadyn <jadyn.wong@live.com> Co-authored-by: Lee Miller <lemiller@microsoft.com>
### Motivation and Context Reduced the amount of warnings given in the project, still some related to namespace and name convention.
### Motivation and Context This fixes the issue raised here: microsoft#1099 Removes unnecessary import Co-authored-by: Alex Chao <achao@achao.localdomain>
…#1083) ### Motivation and Context Improve error messages displayed in copliot chat front end. <img width="1917" alt="betterErrorResponse" src="https://github.com/microsoft/semantic-kernel/assets/51973971/50c37abf-a59e-41e8-a42b-ada975802344"> **Note:** This also involves changes to the semantic kernel, therefore it will be available when new nuget packages are published. Until then you will have to change .\samples\apps\copilot-chat-app\webapi\CopilotChatWebApi.csproj manually to load project reference instead of the respective package references to see this change.
Provide Java settings for gitignore and editorconfig Co-authored-by: Mark Wallace <127216156+markwallace-microsoft@users.noreply.github.com>
### Motivation and Context This PR provides integration tests to reproduce the issue microsoft#1050 ### Description These notes will help understanding how your code works. Thanks! --> Co-authored-by: Roger Barreto <19890735+RogerBarreto@users.noreply.github.com>
…ntic-kernel into merge-upstream-4
github-actions
bot
removed
.NET
markwallace-microsoft
merged commit 4adc2ad
into
microsoft:experimental-java
4 checks passed
shawncal
added a commit
that referenced
this pull request
May 22, 2023
### Motivation and Context <!-- Thank you for your contribution to the semantic-kernel repo! Please help reviewers and future users, providing the following information: 1. Why is this change required? 2. What problem does it solve? 3. What scenario does it contribute to? 4. If it fixes an open issue, please link to the issue here. --> ### Description <!-- Describe your changes, the overall approach, the underlying design. These notes will help understanding how your code works. Thanks! --> ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [ ] The code builds clean without any errors or warnings - [ ] The PR follows SK Contribution Guidelines (https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) - [ ] The code follows the .NET coding conventions (https://learn.microsoft.com/dotnet/csharp/fundamentals/coding-style/coding-conventions) verified with `dotnet format` - [ ] All unit tests pass, and I have added new tests where possible - [ ] I didn't break anyone 😄 --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Milder Hernandez Cagua <milderhc@microsoft.com> Co-authored-by: Milder Hernandez <milderhc@gmail.com> Co-authored-by: Yoshio Terada <tyoshio2002@yahoo.co.jp> Co-authored-by: Mark Wallace <127216156+markwallace-microsoft@users.noreply.github.com> Co-authored-by: name <email> Co-authored-by: Almir Kazazic <kazazic@gmail.com> Co-authored-by: Gudge <mgudgin@microsoft.com> Co-authored-by: Devis Lucato <dluc@users.noreply.github.com> Co-authored-by: Alexander Siniouguine <Woland2k@users.noreply.github.com> Co-authored-by: Harleen Thind <39630244+hathind-ms@users.noreply.github.com> Co-authored-by: David Barkol <dabarkol@microsoft.com> Co-authored-by: Adrian Bonar <56417140+adrianwyatt@users.noreply.github.com> Co-authored-by: Mark Karle <mkarle@users.noreply.github.com> Co-authored-by: poweihuang0817 <131632377+poweihuang0817@users.noreply.github.com> Co-authored-by: Po-Wei Huang <pohuan@microsoft.com> Co-authored-by: Lee Miller <lemiller@microsoft.com> Co-authored-by: Ikko Eltociear Ashimine <eltociear@gmail.com> Co-authored-by: Adrian Bonar (HE/HIM) <adribona@microsoft.com> Co-authored-by: Tao Chen <TaoChenOSU@users.noreply.github.com> Co-authored-by: Teresa Hoang <125500434+teresaqhoang@users.noreply.github.com> Co-authored-by: Gil LaHaye <gillahaye@microsoft.com> Co-authored-by: Shawn Callegari <36091529+shawncal@users.noreply.github.com> Co-authored-by: Vivien Hung <vivihung@microsoft.com> Co-authored-by: Abby Harrison <54643756+awharrison-28@users.noreply.github.com> Co-authored-by: Abby Harrison <abby.harrison@microsoft.com> Co-authored-by: Devis Lucato <devis@microsoft.com> Co-authored-by: Gina Triolo <51341242+gitri-ms@users.noreply.github.com> Co-authored-by: fabio fumarola <fabiofumarola@gmail.com> Co-authored-by: cdMSFT <60192871+cdMSFT@users.noreply.github.com> Co-authored-by: Dmytro Struk <13853051+dmytrostruk@users.noreply.github.com> Co-authored-by: Lex Li <425130+lextm@users.noreply.github.com> Co-authored-by: Damir Dobric <ddobric@daenet.de> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Aman Sachan <51973971+amsacha@users.noreply.github.com> Co-authored-by: Roger Barreto <19890735+RogerBarreto@users.noreply.github.com> Co-authored-by: Stephen Toub <stoub@microsoft.com> Co-authored-by: Craig Presti <146438+craigomatic@users.noreply.github.com> Co-authored-by: Joowon <joowon.kim@dm.snu.ac.kr> Co-authored-by: Richard Edgar <riedgar@microsoft.com> Co-authored-by: nacharya1 <41800911+nacharya1@users.noreply.github.com> Co-authored-by: Kevdome3000 <kbassjr@gmail.com> Co-authored-by: tech <tech@chancetheapp.com> Co-authored-by: Masumi Morishige <masumi.developer@gmail.com> Co-authored-by: adityachallapally <avasanthc@gmail.com> Co-authored-by: Jadyn <jadyn.wong@live.com> Co-authored-by: Alex Chao <5111035+alexchaomander@users.noreply.github.com> Co-authored-by: Alex Chao <achao@achao.localdomain>
5 tasks
This was referenced Aug 1, 2023
johnoliver
added a commit
to johnoliver/semantic-kernel
that referenced
this pull request
Jun 5, 2024
### Motivation and Context <!-- Thank you for your contribution to the semantic-kernel repo! Please help reviewers and future users, providing the following information: 1. Why is this change required? 2. What problem does it solve? 3. What scenario does it contribute to? 4. If it fixes an open issue, please link to the issue here. --> ### Description <!-- Describe your changes, the overall approach, the underlying design. These notes will help understanding how your code works. Thanks! --> ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [ ] The code builds clean without any errors or warnings - [ ] The PR follows SK Contribution Guidelines (https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) - [ ] The code follows the .NET coding conventions (https://learn.microsoft.com/dotnet/csharp/fundamentals/coding-style/coding-conventions) verified with `dotnet format` - [ ] All unit tests pass, and I have added new tests where possible - [ ] I didn't break anyone 😄 --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Milder Hernandez Cagua <milderhc@microsoft.com> Co-authored-by: Milder Hernandez <milderhc@gmail.com> Co-authored-by: Yoshio Terada <tyoshio2002@yahoo.co.jp> Co-authored-by: Mark Wallace <127216156+markwallace-microsoft@users.noreply.github.com> Co-authored-by: name <email> Co-authored-by: Almir Kazazic <kazazic@gmail.com> Co-authored-by: Gudge <mgudgin@microsoft.com> Co-authored-by: Devis Lucato <dluc@users.noreply.github.com> Co-authored-by: Alexander Siniouguine <Woland2k@users.noreply.github.com> Co-authored-by: Harleen Thind <39630244+hathind-ms@users.noreply.github.com> Co-authored-by: David Barkol <dabarkol@microsoft.com> Co-authored-by: Adrian Bonar <56417140+adrianwyatt@users.noreply.github.com> Co-authored-by: Mark Karle <mkarle@users.noreply.github.com> Co-authored-by: poweihuang0817 <131632377+poweihuang0817@users.noreply.github.com> Co-authored-by: Po-Wei Huang <pohuan@microsoft.com> Co-authored-by: Lee Miller <lemiller@microsoft.com> Co-authored-by: Ikko Eltociear Ashimine <eltociear@gmail.com> Co-authored-by: Adrian Bonar (HE/HIM) <adribona@microsoft.com> Co-authored-by: Tao Chen <TaoChenOSU@users.noreply.github.com> Co-authored-by: Teresa Hoang <125500434+teresaqhoang@users.noreply.github.com> Co-authored-by: Gil LaHaye <gillahaye@microsoft.com> Co-authored-by: Shawn Callegari <36091529+shawncal@users.noreply.github.com> Co-authored-by: Vivien Hung <vivihung@microsoft.com> Co-authored-by: Abby Harrison <54643756+awharrison-28@users.noreply.github.com> Co-authored-by: Abby Harrison <abby.harrison@microsoft.com> Co-authored-by: Devis Lucato <devis@microsoft.com> Co-authored-by: Gina Triolo <51341242+gitri-ms@users.noreply.github.com> Co-authored-by: fabio fumarola <fabiofumarola@gmail.com> Co-authored-by: cdMSFT <60192871+cdMSFT@users.noreply.github.com> Co-authored-by: Dmytro Struk <13853051+dmytrostruk@users.noreply.github.com> Co-authored-by: Lex Li <425130+lextm@users.noreply.github.com> Co-authored-by: Damir Dobric <ddobric@daenet.de> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Aman Sachan <51973971+amsacha@users.noreply.github.com> Co-authored-by: Roger Barreto <19890735+RogerBarreto@users.noreply.github.com> Co-authored-by: Stephen Toub <stoub@microsoft.com> Co-authored-by: Craig Presti <146438+craigomatic@users.noreply.github.com> Co-authored-by: Joowon <joowon.kim@dm.snu.ac.kr> Co-authored-by: Richard Edgar <riedgar@microsoft.com> Co-authored-by: nacharya1 <41800911+nacharya1@users.noreply.github.com> Co-authored-by: Kevdome3000 <kbassjr@gmail.com> Co-authored-by: tech <tech@chancetheapp.com> Co-authored-by: Masumi Morishige <masumi.developer@gmail.com> Co-authored-by: adityachallapally <avasanthc@gmail.com> Co-authored-by: Jadyn <jadyn.wong@live.com> Co-authored-by: Alex Chao <5111035+alexchaomander@users.noreply.github.com> Co-authored-by: Alex Chao <achao@achao.localdomain>
johnoliver
added a commit
to johnoliver/semantic-kernel
that referenced
this pull request
Jun 5, 2024
### Motivation and Context <!-- Thank you for your contribution to the semantic-kernel repo! Please help reviewers and future users, providing the following information: 1. Why is this change required? 2. What problem does it solve? 3. What scenario does it contribute to? 4. If it fixes an open issue, please link to the issue here. --> ### Description <!-- Describe your changes, the overall approach, the underlying design. These notes will help understanding how your code works. Thanks! --> ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [ ] The code builds clean without any errors or warnings - [ ] The PR follows SK Contribution Guidelines (https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) - [ ] The code follows the .NET coding conventions (https://learn.microsoft.com/dotnet/csharp/fundamentals/coding-style/coding-conventions) verified with `dotnet format` - [ ] All unit tests pass, and I have added new tests where possible - [ ] I didn't break anyone 😄 --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Milder Hernandez Cagua <milderhc@microsoft.com> Co-authored-by: Milder Hernandez <milderhc@gmail.com> Co-authored-by: Yoshio Terada <tyoshio2002@yahoo.co.jp> Co-authored-by: Mark Wallace <127216156+markwallace-microsoft@users.noreply.github.com> Co-authored-by: name <email> Co-authored-by: Almir Kazazic <kazazic@gmail.com> Co-authored-by: Gudge <mgudgin@microsoft.com> Co-authored-by: Devis Lucato <dluc@users.noreply.github.com> Co-authored-by: Alexander Siniouguine <Woland2k@users.noreply.github.com> Co-authored-by: Harleen Thind <39630244+hathind-ms@users.noreply.github.com> Co-authored-by: David Barkol <dabarkol@microsoft.com> Co-authored-by: Adrian Bonar <56417140+adrianwyatt@users.noreply.github.com> Co-authored-by: Mark Karle <mkarle@users.noreply.github.com> Co-authored-by: poweihuang0817 <131632377+poweihuang0817@users.noreply.github.com> Co-authored-by: Po-Wei Huang <pohuan@microsoft.com> Co-authored-by: Lee Miller <lemiller@microsoft.com> Co-authored-by: Ikko Eltociear Ashimine <eltociear@gmail.com> Co-authored-by: Adrian Bonar (HE/HIM) <adribona@microsoft.com> Co-authored-by: Tao Chen <TaoChenOSU@users.noreply.github.com> Co-authored-by: Teresa Hoang <125500434+teresaqhoang@users.noreply.github.com> Co-authored-by: Gil LaHaye <gillahaye@microsoft.com> Co-authored-by: Shawn Callegari <36091529+shawncal@users.noreply.github.com> Co-authored-by: Vivien Hung <vivihung@microsoft.com> Co-authored-by: Abby Harrison <54643756+awharrison-28@users.noreply.github.com> Co-authored-by: Abby Harrison <abby.harrison@microsoft.com> Co-authored-by: Devis Lucato <devis@microsoft.com> Co-authored-by: Gina Triolo <51341242+gitri-ms@users.noreply.github.com> Co-authored-by: fabio fumarola <fabiofumarola@gmail.com> Co-authored-by: cdMSFT <60192871+cdMSFT@users.noreply.github.com> Co-authored-by: Dmytro Struk <13853051+dmytrostruk@users.noreply.github.com> Co-authored-by: Lex Li <425130+lextm@users.noreply.github.com> Co-authored-by: Damir Dobric <ddobric@daenet.de> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Aman Sachan <51973971+amsacha@users.noreply.github.com> Co-authored-by: Roger Barreto <19890735+RogerBarreto@users.noreply.github.com> Co-authored-by: Stephen Toub <stoub@microsoft.com> Co-authored-by: Craig Presti <146438+craigomatic@users.noreply.github.com> Co-authored-by: Joowon <joowon.kim@dm.snu.ac.kr> Co-authored-by: Richard Edgar <riedgar@microsoft.com> Co-authored-by: nacharya1 <41800911+nacharya1@users.noreply.github.com> Co-authored-by: Kevdome3000 <kbassjr@gmail.com> Co-authored-by: tech <tech@chancetheapp.com> Co-authored-by: Masumi Morishige <masumi.developer@gmail.com> Co-authored-by: adityachallapally <avasanthc@gmail.com> Co-authored-by: Jadyn <jadyn.wong@live.com> Co-authored-by: Alex Chao <5111035+alexchaomander@users.noreply.github.com> Co-authored-by: Alex Chao <achao@achao.localdomain>
johnoliver
added a commit
to johnoliver/semantic-kernel
that referenced
this pull request
Jun 5, 2024
### Motivation and Context <!-- Thank you for your contribution to the semantic-kernel repo! Please help reviewers and future users, providing the following information: 1. Why is this change required? 2. What problem does it solve? 3. What scenario does it contribute to? 4. If it fixes an open issue, please link to the issue here. --> ### Description <!-- Describe your changes, the overall approach, the underlying design. These notes will help understanding how your code works. Thanks! --> ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [ ] The code builds clean without any errors or warnings - [ ] The PR follows SK Contribution Guidelines (https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) - [ ] The code follows the .NET coding conventions (https://learn.microsoft.com/dotnet/csharp/fundamentals/coding-style/coding-conventions) verified with `dotnet format` - [ ] All unit tests pass, and I have added new tests where possible - [ ] I didn't break anyone 😄 --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Milder Hernandez Cagua <milderhc@microsoft.com> Co-authored-by: Milder Hernandez <milderhc@gmail.com> Co-authored-by: Yoshio Terada <tyoshio2002@yahoo.co.jp> Co-authored-by: Mark Wallace <127216156+markwallace-microsoft@users.noreply.github.com> Co-authored-by: name <email> Co-authored-by: Almir Kazazic <kazazic@gmail.com> Co-authored-by: Gudge <mgudgin@microsoft.com> Co-authored-by: Devis Lucato <dluc@users.noreply.github.com> Co-authored-by: Alexander Siniouguine <Woland2k@users.noreply.github.com> Co-authored-by: Harleen Thind <39630244+hathind-ms@users.noreply.github.com> Co-authored-by: David Barkol <dabarkol@microsoft.com> Co-authored-by: Adrian Bonar <56417140+adrianwyatt@users.noreply.github.com> Co-authored-by: Mark Karle <mkarle@users.noreply.github.com> Co-authored-by: poweihuang0817 <131632377+poweihuang0817@users.noreply.github.com> Co-authored-by: Po-Wei Huang <pohuan@microsoft.com> Co-authored-by: Lee Miller <lemiller@microsoft.com> Co-authored-by: Ikko Eltociear Ashimine <eltociear@gmail.com> Co-authored-by: Adrian Bonar (HE/HIM) <adribona@microsoft.com> Co-authored-by: Tao Chen <TaoChenOSU@users.noreply.github.com> Co-authored-by: Teresa Hoang <125500434+teresaqhoang@users.noreply.github.com> Co-authored-by: Gil LaHaye <gillahaye@microsoft.com> Co-authored-by: Shawn Callegari <36091529+shawncal@users.noreply.github.com> Co-authored-by: Vivien Hung <vivihung@microsoft.com> Co-authored-by: Abby Harrison <54643756+awharrison-28@users.noreply.github.com> Co-authored-by: Abby Harrison <abby.harrison@microsoft.com> Co-authored-by: Devis Lucato <devis@microsoft.com> Co-authored-by: Gina Triolo <51341242+gitri-ms@users.noreply.github.com> Co-authored-by: fabio fumarola <fabiofumarola@gmail.com> Co-authored-by: cdMSFT <60192871+cdMSFT@users.noreply.github.com> Co-authored-by: Dmytro Struk <13853051+dmytrostruk@users.noreply.github.com> Co-authored-by: Lex Li <425130+lextm@users.noreply.github.com> Co-authored-by: Damir Dobric <ddobric@daenet.de> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Aman Sachan <51973971+amsacha@users.noreply.github.com> Co-authored-by: Roger Barreto <19890735+RogerBarreto@users.noreply.github.com> Co-authored-by: Stephen Toub <stoub@microsoft.com> Co-authored-by: Craig Presti <146438+craigomatic@users.noreply.github.com> Co-authored-by: Joowon <joowon.kim@dm.snu.ac.kr> Co-authored-by: Richard Edgar <riedgar@microsoft.com> Co-authored-by: nacharya1 <41800911+nacharya1@users.noreply.github.com> Co-authored-by: Kevdome3000 <kbassjr@gmail.com> Co-authored-by: tech <tech@chancetheapp.com> Co-authored-by: Masumi Morishige <masumi.developer@gmail.com> Co-authored-by: adityachallapally <avasanthc@gmail.com> Co-authored-by: Jadyn <jadyn.wong@live.com> Co-authored-by: Alex Chao <5111035+alexchaomander@users.noreply.github.com> Co-authored-by: Alex Chao <achao@achao.localdomain>
johnoliver
added a commit
to johnoliver/semantic-kernel
that referenced
this pull request
Jun 5, 2024
### Motivation and Context <!-- Thank you for your contribution to the semantic-kernel repo! Please help reviewers and future users, providing the following information: 1. Why is this change required? 2. What problem does it solve? 3. What scenario does it contribute to? 4. If it fixes an open issue, please link to the issue here. --> ### Description <!-- Describe your changes, the overall approach, the underlying design. These notes will help understanding how your code works. Thanks! --> ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [ ] The code builds clean without any errors or warnings - [ ] The PR follows SK Contribution Guidelines (https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) - [ ] The code follows the .NET coding conventions (https://learn.microsoft.com/dotnet/csharp/fundamentals/coding-style/coding-conventions) verified with `dotnet format` - [ ] All unit tests pass, and I have added new tests where possible - [ ] I didn't break anyone 😄 --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Milder Hernandez Cagua <milderhc@microsoft.com> Co-authored-by: Milder Hernandez <milderhc@gmail.com> Co-authored-by: Yoshio Terada <tyoshio2002@yahoo.co.jp> Co-authored-by: Mark Wallace <127216156+markwallace-microsoft@users.noreply.github.com> Co-authored-by: name <email> Co-authored-by: Almir Kazazic <kazazic@gmail.com> Co-authored-by: Gudge <mgudgin@microsoft.com> Co-authored-by: Devis Lucato <dluc@users.noreply.github.com> Co-authored-by: Alexander Siniouguine <Woland2k@users.noreply.github.com> Co-authored-by: Harleen Thind <39630244+hathind-ms@users.noreply.github.com> Co-authored-by: David Barkol <dabarkol@microsoft.com> Co-authored-by: Adrian Bonar <56417140+adrianwyatt@users.noreply.github.com> Co-authored-by: Mark Karle <mkarle@users.noreply.github.com> Co-authored-by: poweihuang0817 <131632377+poweihuang0817@users.noreply.github.com> Co-authored-by: Po-Wei Huang <pohuan@microsoft.com> Co-authored-by: Lee Miller <lemiller@microsoft.com> Co-authored-by: Ikko Eltociear Ashimine <eltociear@gmail.com> Co-authored-by: Adrian Bonar (HE/HIM) <adribona@microsoft.com> Co-authored-by: Tao Chen <TaoChenOSU@users.noreply.github.com> Co-authored-by: Teresa Hoang <125500434+teresaqhoang@users.noreply.github.com> Co-authored-by: Gil LaHaye <gillahaye@microsoft.com> Co-authored-by: Shawn Callegari <36091529+shawncal@users.noreply.github.com> Co-authored-by: Vivien Hung <vivihung@microsoft.com> Co-authored-by: Abby Harrison <54643756+awharrison-28@users.noreply.github.com> Co-authored-by: Abby Harrison <abby.harrison@microsoft.com> Co-authored-by: Devis Lucato <devis@microsoft.com> Co-authored-by: Gina Triolo <51341242+gitri-ms@users.noreply.github.com> Co-authored-by: fabio fumarola <fabiofumarola@gmail.com> Co-authored-by: cdMSFT <60192871+cdMSFT@users.noreply.github.com> Co-authored-by: Dmytro Struk <13853051+dmytrostruk@users.noreply.github.com> Co-authored-by: Lex Li <425130+lextm@users.noreply.github.com> Co-authored-by: Damir Dobric <ddobric@daenet.de> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Aman Sachan <51973971+amsacha@users.noreply.github.com> Co-authored-by: Roger Barreto <19890735+RogerBarreto@users.noreply.github.com> Co-authored-by: Stephen Toub <stoub@microsoft.com> Co-authored-by: Craig Presti <146438+craigomatic@users.noreply.github.com> Co-authored-by: Joowon <joowon.kim@dm.snu.ac.kr> Co-authored-by: Richard Edgar <riedgar@microsoft.com> Co-authored-by: nacharya1 <41800911+nacharya1@users.noreply.github.com> Co-authored-by: Kevdome3000 <kbassjr@gmail.com> Co-authored-by: tech <tech@chancetheapp.com> Co-authored-by: Masumi Morishige <masumi.developer@gmail.com> Co-authored-by: adityachallapally <avasanthc@gmail.com> Co-authored-by: Jadyn <jadyn.wong@live.com> Co-authored-by: Alex Chao <5111035+alexchaomander@users.noreply.github.com> Co-authored-by: Alex Chao <achao@achao.localdomain>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Description
Contribution Checklist
dotnet format