Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy CORS correctly #1116

Merged
merged 2 commits into from
May 19, 2023
Merged

Deploy CORS correctly #1116

merged 2 commits into from
May 19, 2023

Conversation

glahaye
Copy link
Contributor

@glahaye glahaye commented May 19, 2023

Motivation and Context

Due to one of the many changes that came in recently, we get CORS problems when trying to access the Copilot Chat from the frontend when deployed using our templates.

Description

  • Change templates to properly deploy CORS.
  • Add some documentation around CORS.

Contribution Checklist

@adrianwyatt adrianwyatt self-assigned this May 19, 2023
@adrianwyatt adrianwyatt enabled auto-merge (squash) May 19, 2023 21:27
@adrianwyatt adrianwyatt merged commit fc0f0ac into microsoft:main May 19, 2023
shawncal pushed a commit to shawncal/semantic-kernel that referenced this pull request Jul 6, 2023
### Motivation and Context
Due to one of the many changes that came in recently, we get CORS
problems when trying to access the Copilot Chat from the frontend when
deployed using our templates.

### Description
- Change templates to properly deploy CORS.
- Add some documentation around CORS.
golden-aries pushed a commit to golden-aries/semantic-kernel that referenced this pull request Oct 10, 2023
### Motivation and Context
Due to one of the many changes that came in recently, we get CORS
problems when trying to access the Copilot Chat from the frontend when
deployed using our templates.

### Description
- Change templates to properly deploy CORS.
- Add some documentation around CORS.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants