OpenAPIDocumentParser class clean-up. #1390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
.NET
SergeyMenshykh
added
.NET
teresaqhoang
approved these changes
Jun 9, 2023
shawncal
force-pushed
the
open-api-clean-up
branch
from
6ecce6a
to
783871c
Compare
lemillermicrosoft
approved these changes
Jun 12, 2023
shawncal
pushed a commit
to shawncal/semantic-kernel
that referenced
this pull request
Jul 6, 2023
### Description and Motivation The OpenAPIDocumentParser class has been updated to make it kernel-agnostic and enable easy reuse in other components where the conversion functionality may not be needed or may be different. **Disclaimer**: The conversion logic has not been changed, and the purpose of this pull request is solely to relocate the conversion logic from the parser class and not to enhance the logic itself.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description and Motivation
The OpenAPIDocumentParser class has been updated to make it kernel-agnostic and enable easy reuse in other components where the conversion functionality may not be needed or may be different.
Disclaimer: The conversion logic has not been changed, and the purpose of this pull request is solely to relocate the conversion logic from the parser class and not to enhance the logic itself.
Contribution Checklist
dotnet format