TextCompletion Fixes + Interface simplification #1391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RogerBarreto
added
bug
github-actions
bot
added
the
kernel
…nto features/itextcompletion-simpleinterfaces
dotnet/src/SemanticKernel.Abstractions/AI/TextCompletion/ITextStreamingResult.cs
Show resolved
Hide resolved
5 tasks
RogerBarreto
added
PR: ready to merge
lemillermicrosoft
approved these changes
Jun 13, 2023
lemillermicrosoft
requested changes
Jun 13, 2023
lemillermicrosoft
removed
the
PR: ready to merge
…ithub.com/RogerBarreto/semantic-kernel into features/itextcompletion-simpleinterfaces
lemillermicrosoft
previously approved these changes
Jun 13, 2023
lemillermicrosoft
added
PR: ready for review
shawncal
reviewed
Jun 14, 2023
dotnet/src/SemanticKernel.Abstractions/AI/ChatCompletion/ChatCompletionExtensions.cs
Outdated
Show resolved
Hide resolved
shawncal
reviewed
Jun 14, 2023
dotnet/src/SemanticKernel.Abstractions/AI/TextCompletion/TextCompletionExtensions.cs
Show resolved
Hide resolved
shawncal
approved these changes
Jun 15, 2023
shawncal
added a commit
to shawncal/semantic-kernel
that referenced
this pull request
Jul 6, 2023
### Motivation and Context Previous interfaces were too verbose and could be confusing. Removed the extra `Completion` verbosity from the interfaces as marked the old ones as Obsolete. Small bug identified when using the TextCompletion Streaming (awaiting indefinitely) ### Description - Renamed interface `ITextCompletionResult` to `ITextResult` - Renamed interface `ITextCompletionStreamingResult` to `ITextStreamingResult` - BugFix TextCompletion Streaming (was not behaving as expected - awaiting indefinitely for ITextStreamingResult) - Added remarks on the `Complete` Extension methods regarding no support for multiple results. - Added remarks on the `CompleteStreaming` Extension methods regarding no support for multiple results. - Added remarks to extensions methods that don't support multiple results - IChatCompletion.GenerateMessageStreamAsync - IChatCompletion.GenerateMessageAsync - ITextCompletion.CompleteStreamAsync - ITextCompletion.CompleteAsync Co-authored-by: Lee Miller <lemiller@microsoft.com> Co-authored-by: Shawn Callegari <36091529+shawncal@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Previous interfaces where too verbose and could be confusing.
Removed the extra
Completionverbosity from the interfaces as marked the old ones as Obsolete.Small bug identified when using the TextCompletion Streaming (awaiting indefinitely)
Description
ITextCompletionResulttoITextResultITextCompletionStreamingResulttoITextStreamingResultCompleteExtension methods regarding no support for multiple results.CompleteStreamingExtension methods regarding no support for multiple results.Contribution Checklist
dotnet format