Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .NET 7.0 SDK feature to devcontainer configuration #1424

Merged
merged 3 commits into from
Jun 14, 2023
Merged

Add .NET 7.0 SDK feature to devcontainer configuration #1424

merged 3 commits into from
Jun 14, 2023

Conversation

pjirsa
Copy link
Contributor

@pjirsa pjirsa commented Jun 12, 2023

Motivation and Context

Resolves #1421 by specifying .NET 7.0 SDK as feature for dev container to install.

@craigomatic
Copy link
Contributor

I tried to validate this in a codespaces against this branch/PR and I'm seeing this:

image

It does look like the change you made has come across:

image

Any suggestions on what I should try to validate the fix?

shawncal
shawncal previously approved these changes Jun 13, 2023
@shawncal shawncal dismissed their stale review June 13, 2023 02:07

Await resolution of @craigomatic

@pjirsa
Copy link
Contributor Author

pjirsa commented Jun 13, 2023

@craigomatic - If you had it open in a Codespace previously, you will need to rebuild the container and reopen.

@craigomatic craigomatic added the PR: ready to merge PR has been approved by all reviewers, and is ready to merge. label Jun 13, 2023
Copy link
Contributor

@craigomatic craigomatic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My issue seemed to be a one-off, everything is working as expected. LGTM

@adrianwyatt adrianwyatt enabled auto-merge (squash) June 14, 2023 00:53
@adrianwyatt adrianwyatt merged commit 08bc3cc into microsoft:main Jun 14, 2023
shawncal pushed a commit to shawncal/semantic-kernel that referenced this pull request Jul 6, 2023
### Motivation and Context
Resolves microsoft#1421 by specifying .NET 7.0 SDK as feature for dev container
to install.

Co-authored-by: Craig Presti <146438+craigomatic@users.noreply.github.com>
johnoliver pushed a commit to johnoliver/semantic-kernel that referenced this pull request Jun 5, 2024
### Motivation and Context
Resolves microsoft#1421 by specifying .NET 7.0 SDK as feature for dev container
to install.

Co-authored-by: Craig Presti <146438+craigomatic@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: ready to merge PR has been approved by all reviewers, and is ready to merge.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DevContainer - missing required .NET 7.0 SDK for Polyglot notebook extension
4 participants