Fix parameter assignment in ActionPlanner #1530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
.NET
shawncal
force-pushed
the
616_action_substep
branch
from
2b6e31c
to
9cf2d79
Compare
This commit fixes a bug where the plan state was incorrectly updated instead of the plan parameters. It also adds descriptions for the SKFunction attributes of the ActionPlanner class, to make them more readable and understandable. Additionally, it formats the parameters of the functions to follow the coding style guidelines.
lemillermicrosoft
force-pushed
the
616_action_substep
branch
from
9cf2d79
to
3d72c16
Compare
shawncal
approved these changes
Jun 16, 2023
lemillermicrosoft
removed this pull request from the merge queue due to a manual request
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
markwallace-microsoft
pushed a commit
to markwallace-microsoft/semantic-kernel
that referenced
this pull request
Jun 23, 2023
### Motivation and Context This pull request fixes a bug in the ActionPlanner class where the plan parameters were not assigned correctly from the input parameters. It also updates some formatting Fixes microsoft#997 ### Description - Fix parameter assignment in ActionPlanner.CreatePlanFromParameters method - Use plan.Parameters instead of plan.State to assign the input parameters to the plan object - This fixes a bug where the plan state was overwritten by the input parameters, causing unexpected behavior and errors ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [x] The code builds clean without any errors or warnings - [x] The PR follows SK Contribution Guidelines (https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) - [x] The code follows the .NET coding conventions (https://learn.microsoft.com/dotnet/csharp/fundamentals/coding-style/coding-conventions) verified with `dotnet format` - [ ] All unit tests pass, and I have added new tests where possible - [x] I didn't break anyone 😄 --------- Co-authored-by: Lee Miller <lemillermicrosoft@users.noreply.github.com>
shawncal
pushed a commit
to shawncal/semantic-kernel
that referenced
this pull request
Jul 6, 2023
### Motivation and Context This pull request fixes a bug in the ActionPlanner class where the plan parameters were not assigned correctly from the input parameters. It also updates some formatting Fixes microsoft#997 ### Description - Fix parameter assignment in ActionPlanner.CreatePlanFromParameters method - Use plan.Parameters instead of plan.State to assign the input parameters to the plan object - This fixes a bug where the plan state was overwritten by the input parameters, causing unexpected behavior and errors ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [x] The code builds clean without any errors or warnings - [x] The PR follows SK Contribution Guidelines (https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) - [x] The code follows the .NET coding conventions (https://learn.microsoft.com/dotnet/csharp/fundamentals/coding-style/coding-conventions) verified with `dotnet format` - [ ] All unit tests pass, and I have added new tests where possible - [x] I didn't break anyone 😄 --------- Co-authored-by: Lee Miller <lemillermicrosoft@users.noreply.github.com>
golden-aries
pushed a commit
to golden-aries/semantic-kernel
that referenced
this pull request
Oct 10, 2023
### Motivation and Context This pull request fixes a bug in the ActionPlanner class where the plan parameters were not assigned correctly from the input parameters. It also updates some formatting Fixes microsoft#997 ### Description - Fix parameter assignment in ActionPlanner.CreatePlanFromParameters method - Use plan.Parameters instead of plan.State to assign the input parameters to the plan object - This fixes a bug where the plan state was overwritten by the input parameters, causing unexpected behavior and errors ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [x] The code builds clean without any errors or warnings - [x] The PR follows SK Contribution Guidelines (https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) - [x] The code follows the .NET coding conventions (https://learn.microsoft.com/dotnet/csharp/fundamentals/coding-style/coding-conventions) verified with `dotnet format` - [ ] All unit tests pass, and I have added new tests where possible - [x] I didn't break anyone 😄 --------- Co-authored-by: Lee Miller <lemillermicrosoft@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
This pull request fixes a bug in the ActionPlanner class where the plan parameters were not assigned correctly from the input parameters. It also updates some formatting
Fixes #997
Description
Contribution Checklist
dotnet format