Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Redis Connector README.md with various options to get RediSearch #1686

Merged
merged 3 commits into from
Jul 3, 2023

Conversation

shpathak-msft
Copy link
Contributor

@shpathak-msft shpathak-msft commented Jun 22, 2023

Improve on the options to get RediSearch.

Motivation and Context

Description

Contribution Checklist

Improve on the options to get RediSearch.
@shpathak-msft shpathak-msft requested a review from a team as a code owner June 22, 2023 22:48
@github-actions github-actions bot added .NET Issue or Pull requests regarding .NET code kernel Issues or pull requests impacting the core kernel labels Jun 22, 2023
@dmytrostruk dmytrostruk added PR: ready to merge PR has been approved by all reviewers, and is ready to merge. docs and tests Improvements or additions to documentation labels Jun 27, 2023
@shawncal shawncal added this pull request to the merge queue Jul 3, 2023
Merged via the queue into microsoft:main with commit 4eaee80 Jul 3, 2023
shawncal pushed a commit to shawncal/semantic-kernel that referenced this pull request Jul 6, 2023
…ch (microsoft#1686)

Improve on the options to get RediSearch.

### Motivation and Context
<!-- Thank you for your contribution to the semantic-kernel repo!
Please help reviewers and future users, providing the following
information:
  1. Why is this change required?
  2. What problem does it solve?
  3. What scenario does it contribute to?
  4. If it fixes an open issue, please link to the issue here.
-->


### Description
<!-- Describe your changes, the overall approach, the underlying design.
These notes will help understanding how your code works. Thanks! -->


### Contribution Checklist
<!-- Before submitting this PR, please make sure: -->
- [ ] The code builds clean without any errors or warnings
- [ ] The PR follows SK Contribution Guidelines
(https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md)
- [ ] The code follows the .NET coding conventions
(https://learn.microsoft.com/dotnet/csharp/fundamentals/coding-style/coding-conventions)
verified with `dotnet format`
- [ ] All unit tests pass, and I have added new tests where possible
- [x] I didn't break anyone 😄

Co-authored-by: Dmytro Struk <13853051+dmytrostruk@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs and tests Improvements or additions to documentation kernel Issues or pull requests impacting the core kernel .NET Issue or Pull requests regarding .NET code PR: ready to merge PR has been approved by all reviewers, and is ready to merge.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants