updated copilot chat deployment readme based on learnings #1711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TaoChenOSU
reviewed
Jun 26, 2023
TaoChenOSU
previously approved these changes
Jun 26, 2023
gitri-ms
approved these changes
Jun 26, 2023
gitri-ms
added
the
PR: ready to merge
alliscode
approved these changes
Jun 27, 2023
shawncal
pushed a commit
to shawncal/semantic-kernel
that referenced
this pull request
Jul 6, 2023
…1711) ### Motivation and Context Thank you for this great addition where we can deploy the SK copilot chat to an azure subscription. I went through the process and stumbled into some issues. I updated the readme to solve those issues for others that want to do the same... Additionally, I updated the deploy-webapp ps1 and sh files to auto update the aad appregistration (set the redirect uri to the newly deployed front end) ### Description updated copilot chat deployment readme based on learnings: 1. I had to update my Azure CLI (a bit too old) as the deployment of the webapp gave a strange error. I added a note that updating the CLI is a good idea 2. To deploy the webapp, the readme only contained the bash command. Since there is also a ps1 script available, I added the command to use this one 3. updated both `deploy-webapp.ps1`and `deploy-webapp.sh` to ensure that the AAD app registration is updated to auto redirect to the correct url (webapp) and not show an nasty AAD error. > small note, I tested the updated `deploy-webapp.ps1`, but bot the `deploy-webapp.sh` as I did my deployment with powershell... should not be a problem though as it is a call to the AZ CLI ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [x] The code builds clean without any errors or warnings - [x] The PR follows SK Contribution Guidelines (https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) - [x] The code follows the .NET coding conventions (https://learn.microsoft.com/dotnet/csharp/fundamentals/coding-style/coding-conventions) verified with `dotnet format` - [x] All unit tests pass, and I have added new tests where possible - [x] I didn't break anyone 😄 --------- Co-authored-by: Gina Triolo <51341242+gitri-ms@users.noreply.github.com>
golden-aries
pushed a commit
to golden-aries/semantic-kernel
that referenced
this pull request
Oct 10, 2023
…1711) ### Motivation and Context Thank you for this great addition where we can deploy the SK copilot chat to an azure subscription. I went through the process and stumbled into some issues. I updated the readme to solve those issues for others that want to do the same... Additionally, I updated the deploy-webapp ps1 and sh files to auto update the aad appregistration (set the redirect uri to the newly deployed front end) ### Description updated copilot chat deployment readme based on learnings: 1. I had to update my Azure CLI (a bit too old) as the deployment of the webapp gave a strange error. I added a note that updating the CLI is a good idea 2. To deploy the webapp, the readme only contained the bash command. Since there is also a ps1 script available, I added the command to use this one 3. updated both `deploy-webapp.ps1`and `deploy-webapp.sh` to ensure that the AAD app registration is updated to auto redirect to the correct url (webapp) and not show an nasty AAD error. > small note, I tested the updated `deploy-webapp.ps1`, but bot the `deploy-webapp.sh` as I did my deployment with powershell... should not be a problem though as it is a call to the AZ CLI ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [x] The code builds clean without any errors or warnings - [x] The PR follows SK Contribution Guidelines (https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) - [x] The code follows the .NET coding conventions (https://learn.microsoft.com/dotnet/csharp/fundamentals/coding-style/coding-conventions) verified with `dotnet format` - [x] All unit tests pass, and I have added new tests where possible - [x] I didn't break anyone 😄 --------- Co-authored-by: Gina Triolo <51341242+gitri-ms@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Thank you for this great addition where we can deploy the SK copilot chat to an azure subscription. I went through the process and stumbled into some issues. I updated the readme to solve those issues for others that want to do the same... Additionally, I updated the deploy-webapp ps1 and sh files to auto update the aad appregistration (set the redirect uri to the newly deployed front end)
Description
updated copilot chat deployment readme based on learnings:
deploy-webapp.ps1anddeploy-webapp.shto ensure that the AAD app registration is updated to auto redirect to the correct url (webapp) and not show an nasty AAD error.Contribution Checklist
dotnet format