.Net: Loosen TextChunker's lines input type #5502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It currently requires a `List<string>`. This both annoying and unnecessary. I also removed duplicative experimental attributes.
github-actions
bot
changed the title
markwallace-microsoft
approved these changes
Mar 19, 2024
stephentoub
force-pushed
the
textchunkerenumerable
branch
from
fc2f1f1
to
06f7ccd
Compare
Done. Thanks. |
RogerBarreto
approved these changes
Mar 19, 2024
LudoCorporateShark
pushed a commit
to LudoCorporateShark/semantic-kernel
that referenced
this pull request
Aug 25, 2024
It currently requires a `List<string>`. This both annoying and unnecessary. I also removed duplicative experimental attributes. (Note this is a binary breaking change, not source breaking, but the type is marked experimental.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It currently requires a
List<string>. This both annoying and unnecessary.I also removed duplicative experimental attributes.
(Note this is a binary breaking change, not source breaking, but the type is marked experimental.)