Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.Net: Fix handling of generic return types in CreateFromMethod #5821

Merged
merged 2 commits into from
Apr 9, 2024

Conversation

stephentoub
Copy link
Member

@stephentoub stephentoub commented Apr 9, 2024

Fixes #5587

Easiest to review with whitespace disabled: https://github.com/microsoft/semantic-kernel/pull/5821/files?w=1

@stephentoub stephentoub requested a review from a team as a code owner April 9, 2024 18:21
@markwallace-microsoft markwallace-microsoft added .NET Issue or Pull requests regarding .NET code kernel Issues or pull requests impacting the core kernel labels Apr 9, 2024
@github-actions github-actions bot changed the title Fix handling of generic return types in CreateFromMethod .Net: Fix handling of generic return types in CreateFromMethod Apr 9, 2024
@stephentoub stephentoub added this pull request to the merge queue Apr 9, 2024
Merged via the queue into microsoft:main with commit e74c742 Apr 9, 2024
15 checks passed
@stephentoub stephentoub deleted the fixgenericreturn branch April 9, 2024 21:43
LudoCorporateShark pushed a commit to LudoCorporateShark/semantic-kernel that referenced this pull request Aug 25, 2024
…soft#5821)

Fixes microsoft#5587

Easiest to review with whitespace disabled:
https://github.com/microsoft/semantic-kernel/pull/5821/files?w=1

Co-authored-by: Dmytro Struk <13853051+dmytrostruk@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kernel Issues or pull requests impacting the core kernel .NET Issue or Pull requests regarding .NET code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

.Net: Generic return types for KernelFunctions returns error
3 participants