Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python: mypy coverage for functions #5883

Merged
merged 7 commits into from
Apr 16, 2024
Merged

Python: mypy coverage for functions #5883

merged 7 commits into from
Apr 16, 2024

Conversation

eavanvalkenburg
Copy link
Member

Motivation and Context

extend mypy typing coverage to all classes in 'functions' folder.

Description

Contribution Checklist

@eavanvalkenburg eavanvalkenburg requested a review from a team as a code owner April 16, 2024 12:43
@markwallace-microsoft markwallace-microsoft added the python Pull requests for the Python Semantic Kernel label Apr 16, 2024
@markwallace-microsoft
Copy link
Member

markwallace-microsoft commented Apr 16, 2024 •
edited
Loading

Py3.8 Test Coverage

Python 3.8 Test Coverage Report •
FileStmtsMissCoverMissing
semantic_kernel
   kernel.py2612889%122, 124, 182–185, 187–191, 193–196, 203, 210–219, 254–257, 267–272, 277, 281–284, 466–467
semantic_kernel/connectors/ai
   chat_completion_client_base.py12192%18
semantic_kernel/connectors/ai/hugging_face/services
   hf_text_completion.py42686%97–98, 101, 127, 148–149
semantic_kernel/connectors/ai/ollama/services
   ollama_chat_completion.py70691%57, 93, 113, 131, 164, 183
   ollama_text_completion.py42198%97
semantic_kernel/connectors/ai/open_ai/services
   open_ai_chat_completion_base.py1716264%112, 134–137, 139–142, 159–162, 172–175, 186–209, 218–220, 237–239, 262, 270, 276–282, 293–299, 335–341, 359, 378–380
   open_ai_text_completion_base.py582655%66–69, 92–109, 115–118, 137, 145
semantic_kernel/connectors/openapi_plugin
   openapi_manager.py1411589%13, 61–74, 104, 145, 150, 280, 348–361
semantic_kernel/functions
   function_result.py30970%45, 47–48, 58–63
   kernel_function.py72297%141, 160
   kernel_function_decorator.py67199%101
   kernel_function_from_method.py84495%150–151, 157–158
   kernel_function_from_prompt.py162498%170, 198, 299, 369
   prompt_rendering_result.py880%3–23
TOTAL5546101082% 

Python 3.8 Unit Test Overview

Tests Skipped Failures Errors Time
1211 11 💤 0 ❌ 0 🔥 19.586s ⏱️

juliomenendez
juliomenendez approved these changes Apr 16, 2024
View reviewed changes
Copy link
Contributor

@juliomenendez juliomenendez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eavanvalkenburg eavanvalkenburg added this pull request to the merge queue Apr 16, 2024
Merged via the queue into microsoft:main with commit dc54c6f Apr 16, 2024
30 checks passed
@eavanvalkenburg eavanvalkenburg deleted the typing_function branch April 16, 2024 14:29
johnoliver pushed a commit to johnoliver/semantic-kernel that referenced this pull request Jun 5, 2024
@eavanvalkenburg
Python: mypy coverage for functions (microsoft#5883)
2be3ecb 
### Motivation and Context

<!-- Thank you for your contribution to the semantic-kernel repo!
Please help reviewers and future users, providing the following
information:
  1. Why is this change required?
  2. What problem does it solve?
  3. What scenario does it contribute to?
  4. If it fixes an open issue, please link to the issue here.
-->
extend mypy typing coverage to all classes in 'functions' folder.

### Description

<!-- Describe your changes, the overall approach, the underlying design.
These notes will help understanding how your code works. Thanks! -->

### Contribution Checklist

<!-- Before submitting this PR, please make sure: -->

- [x] The code builds clean without any errors or warnings
- [x] The PR follows the [SK Contribution
Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md)
and the [pre-submission formatting
script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts)
raises no violations
- [x] All unit tests pass, and I have added new tests where possible
- [x] I didn't break anyone 😄
johnoliver pushed a commit to johnoliver/semantic-kernel that referenced this pull request Jun 5, 2024
@eavanvalkenburg
Python: mypy coverage for functions (microsoft#5883)
a7b6e3f 
### Motivation and Context

<!-- Thank you for your contribution to the semantic-kernel repo!
Please help reviewers and future users, providing the following
information:
  1. Why is this change required?
  2. What problem does it solve?
  3. What scenario does it contribute to?
  4. If it fixes an open issue, please link to the issue here.
-->
extend mypy typing coverage to all classes in 'functions' folder.

### Description

<!-- Describe your changes, the overall approach, the underlying design.
These notes will help understanding how your code works. Thanks! -->

### Contribution Checklist

<!-- Before submitting this PR, please make sure: -->

- [x] The code builds clean without any errors or warnings
- [x] The PR follows the [SK Contribution
Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md)
and the [pre-submission formatting
script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts)
raises no violations
- [x] All unit tests pass, and I have added new tests where possible
- [x] I didn't break anyone 😄
LudoCorporateShark pushed a commit to LudoCorporateShark/semantic-kernel that referenced this pull request Aug 25, 2024
@eavanvalkenburg
Python: mypy coverage for functions (microsoft#5883)
338f681 
### Motivation and Context

<!-- Thank you for your contribution to the semantic-kernel repo!
Please help reviewers and future users, providing the following
information:
  1. Why is this change required?
  2. What problem does it solve?
  3. What scenario does it contribute to?
  4. If it fixes an open issue, please link to the issue here.
-->
extend mypy typing coverage to all classes in 'functions' folder.

### Description

<!-- Describe your changes, the overall approach, the underlying design.
These notes will help understanding how your code works. Thanks! -->

### Contribution Checklist

<!-- Before submitting this PR, please make sure: -->

- [x] The code builds clean without any errors or warnings
- [x] The PR follows the [SK Contribution
Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md)
and the [pre-submission formatting
script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts)
raises no violations
- [x] All unit tests pass, and I have added new tests where possible
- [x] I didn't break anyone 😄
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moonbox3 moonbox3 moonbox3 approved these changes

@juliomenendez juliomenendez juliomenendez approved these changes

Assignees
No one assigned
Labels
python Pull requests for the Python Semantic Kernel
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@eavanvalkenburg @markwallace-microsoft @juliomenendez @moonbox3