Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.Net: Added dimensions property to OpenAI embedding service constructor #6184

Merged
merged 2 commits into from
May 10, 2024

Conversation

dmytrostruk
Copy link
Member

Motivation and Context

Fixes: #6182

Contribution Checklist

@dmytrostruk dmytrostruk self-assigned this May 10, 2024
@dmytrostruk dmytrostruk requested a review from a team as a code owner May 10, 2024 15:13
@markwallace-microsoft markwallace-microsoft added .NET Issue or Pull requests regarding .NET code kernel Issues or pull requests impacting the core kernel labels May 10, 2024
@dmytrostruk dmytrostruk added this pull request to the merge queue May 10, 2024
Merged via the queue into microsoft:main with commit d45d3bd May 10, 2024
15 checks passed
@dmytrostruk dmytrostruk deleted the openai-dimensions-fix branch May 10, 2024 16:08
LudoCorporateShark pushed a commit to LudoCorporateShark/semantic-kernel that referenced this pull request Aug 25, 2024
…or (microsoft#6184)

### Motivation and Context

<!-- Thank you for your contribution to the semantic-kernel repo!
Please help reviewers and future users, providing the following
information:
  1. Why is this change required?
  2. What problem does it solve?
  3. What scenario does it contribute to?
  4. If it fixes an open issue, please link to the issue here.
-->

Fixes: microsoft#6182

### Contribution Checklist

<!-- Before submitting this PR, please make sure: -->

- [x] The code builds clean without any errors or warnings
- [x] The PR follows the [SK Contribution
Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md)
and the [pre-submission formatting
script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts)
raises no violations
- [x] All unit tests pass, and I have added new tests where possible
- [x] I didn't break anyone 😄
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kernel Issues or pull requests impacting the core kernel .NET Issue or Pull requests regarding .NET code
Projects
None yet
3 participants