Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python: added function_name and plugin_name properties to FC and FCR #6286

Merged
merged 3 commits into from
May 16, 2024

Conversation

eavanvalkenburg
Copy link
Member

Motivation and Context

Fixes #6258

Description

Contribution Checklist

@eavanvalkenburg eavanvalkenburg requested a review from a team as a code owner May 16, 2024 11:20
@markwallace-microsoft markwallace-microsoft added the python Pull requests for the Python Semantic Kernel label May 16, 2024
@markwallace-microsoft
Copy link
Member

markwallace-microsoft commented May 16, 2024

Py3.10 Test Coverage

Python 3.10 Test Coverage Report •
FileStmtsMissCoverMissing
semantic_kernel/contents
   function_call_content.py62592%28, 35, 37, 84, 91
   function_result_content.py44589%51, 55, 70, 95, 100
TOTAL6111108682% 

Python 3.10 Unit Test Overview

Tests Skipped Failures Errors Time
1291 1 💤 0 ❌ 0 🔥 11.698s ⏱️

@eavanvalkenburg eavanvalkenburg added this pull request to the merge queue May 16, 2024
Merged via the queue into microsoft:main with commit a5a38b8 May 16, 2024
25 checks passed
@eavanvalkenburg eavanvalkenburg deleted the fc_properties branch May 16, 2024 14:49
LudoCorporateShark pushed a commit to LudoCorporateShark/semantic-kernel that referenced this pull request Aug 25, 2024
…icrosoft#6286)

### Motivation and Context

<!-- Thank you for your contribution to the semantic-kernel repo!
Please help reviewers and future users, providing the following
information:
  1. Why is this change required?
  2. What problem does it solve?
  3. What scenario does it contribute to?
  4. If it fixes an open issue, please link to the issue here.
-->
Fixes microsoft#6258

### Description

<!-- Describe your changes, the overall approach, the underlying design.
These notes will help understanding how your code works. Thanks! -->

### Contribution Checklist

<!-- Before submitting this PR, please make sure: -->

- [x] The code builds clean without any errors or warnings
- [x] The PR follows the [SK Contribution
Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md)
and the [pre-submission formatting
script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts)
raises no violations
- [x] All unit tests pass, and I have added new tests where possible
- [x] I didn't break anyone 😄
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
python Pull requests for the Python Semantic Kernel
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Python: FunctionCallContent and FunctionResultContent should have plugin_name and function_name
4 participants