Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.Net: Add activities to MistralClient #6297

Merged
merged 1 commit into from
May 16, 2024

Conversation

stephentoub
Copy link
Member

Replicates the ModelDiagnostics stuff to the MistralAI chat completion service implementation.

I still need to test it. Best I can say now is it compiles :)

cc: @markwallace-microsoft, @TaoChenOSU

@stephentoub stephentoub requested a review from a team as a code owner May 16, 2024 17:30
@markwallace-microsoft markwallace-microsoft added .NET Issue or Pull requests regarding .NET code kernel Issues or pull requests impacting the core kernel labels May 16, 2024
@github-actions github-actions bot changed the title Add activities to MistralClient .Net: Add activities to MistralClient May 16, 2024
@TaoChenOSU
Copy link
Contributor

LGTM, I think we should still test it to make sure the metadata and the execution settings are there in the activities.

@markwallace-microsoft markwallace-microsoft added this pull request to the merge queue May 16, 2024
Merged via the queue into microsoft:main with commit aa98754 May 16, 2024
17 checks passed
LudoCorporateShark pushed a commit to LudoCorporateShark/semantic-kernel that referenced this pull request Aug 25, 2024
Replicates the ModelDiagnostics stuff to the MistralAI chat completion
service implementation.

I still need to test it. Best I can say now is it compiles :)

cc: @markwallace-microsoft, @TaoChenOSU
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kernel Issues or pull requests impacting the core kernel .NET Issue or Pull requests regarding .NET code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants