Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python: fix for fc stepwise #6337

Merged
merged 4 commits into from
May 20, 2024
Merged

Conversation

eavanvalkenburg
Copy link
Member

Motivation and Context

fixes #6333

Description

Contribution Checklist

@eavanvalkenburg eavanvalkenburg requested a review from a team as a code owner May 20, 2024 06:58
@markwallace-microsoft markwallace-microsoft added the python Pull requests for the Python Semantic Kernel label May 20, 2024
@markwallace-microsoft
Copy link
Member

markwallace-microsoft commented May 20, 2024

Py3.10 Test Coverage

Python 3.10 Test Coverage Report •
FileStmtsMissCoverMissing
semantic_kernel/connectors/ai/open_ai/services
   open_ai_chat_completion_base.py2119356%97, 117, 142–146, 170, 174, 190–195, 211–240, 243–254, 272–279, 290–298, 314–321, 342, 350, 356–362, 374–380, 411, 450, 452–453, 458–463, 467–474, 496, 505–514
semantic_kernel/planners/function_calling_stepwise_planner
   function_calling_stepwise_planner.py1104262%126–214, 248–253
TOTAL6288104183% 

Python 3.10 Unit Test Overview

Tests Skipped Failures Errors Time
1341 1 💤 0 ❌ 0 🔥 12.200s ⏱️

@eavanvalkenburg eavanvalkenburg added this pull request to the merge queue May 20, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 20, 2024
@moonbox3 moonbox3 enabled auto-merge May 20, 2024 21:04
@moonbox3 moonbox3 added this pull request to the merge queue May 20, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 20, 2024
@moonbox3 moonbox3 enabled auto-merge May 20, 2024 22:03
@moonbox3 moonbox3 added this pull request to the merge queue May 20, 2024
Merged via the queue into microsoft:main with commit 2581350 May 20, 2024
25 checks passed
LudoCorporateShark pushed a commit to LudoCorporateShark/semantic-kernel that referenced this pull request Aug 25, 2024
### Motivation and Context

<!-- Thank you for your contribution to the semantic-kernel repo!
Please help reviewers and future users, providing the following
information:
  1. Why is this change required?
  2. What problem does it solve?
  3. What scenario does it contribute to?
  4. If it fixes an open issue, please link to the issue here.
-->
fixes microsoft#6333 

### Description

<!-- Describe your changes, the overall approach, the underlying design.
These notes will help understanding how your code works. Thanks! -->

### Contribution Checklist

<!-- Before submitting this PR, please make sure: -->

- [x] The code builds clean without any errors or warnings
- [x] The PR follows the [SK Contribution
Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md)
and the [pre-submission formatting
script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts)
raises no violations
- [x] All unit tests pass, and I have added new tests where possible
- [x] I didn't break anyone 😄

Co-authored-by: Evan Mattson <35585003+moonbox3@users.noreply.github.com>
@eavanvalkenburg eavanvalkenburg deleted the fc_fixes branch August 26, 2024 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
python Pull requests for the Python Semantic Kernel
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Python: FunctionCallingStepwisePlanner not working in semantic-kernel 1.0.0rc1 | programming language python
4 participants