-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python: Pydantic settings config #6392
Merged
eavanvalkenburg
merged 14 commits into
microsoft:main
from
eavanvalkenburg:pydantic_settings_config
May 30, 2024
Merged
Python: Pydantic settings config #6392
eavanvalkenburg
merged 14 commits into
microsoft:main
from
eavanvalkenburg:pydantic_settings_config
May 30, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markwallace-microsoft
added
python
Pull requests for the Python Semantic Kernel
memory
labels
May 24, 2024
Python 3.10 Test Coverage Report •
Python 3.10 Unit Test Overview
|
juliomenendez
approved these changes
May 24, 2024
moonbox3
reviewed
May 28, 2024
moonbox3
approved these changes
May 29, 2024
moonbox3
approved these changes
May 29, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
May 29, 2024
moonbox3
reviewed
May 29, 2024
python/semantic_kernel/connectors/ai/google_palm/services/gp_text_completion.py
Show resolved
Hide resolved
moonbox3
approved these changes
May 29, 2024
moonbox3
approved these changes
May 29, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
May 29, 2024
markwallace-microsoft
approved these changes
May 30, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
May 30, 2024
markwallace-microsoft
approved these changes
May 30, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
May 30, 2024
LudoCorporateShark
pushed a commit
to LudoCorporateShark/semantic-kernel
that referenced
this pull request
Aug 25, 2024
### Motivation and Context <!-- Thank you for your contribution to the semantic-kernel repo! Please help reviewers and future users, providing the following information: 1. Why is this change required? 2. What problem does it solve? 3. What scenario does it contribute to? 4. If it fixes an open issue, please link to the issue here. --> The initial implementation of Pydantic Settings was not optimal yet, more optimized now. ### Description Added a KernelBaseSettings class in kernel_pydantic Rebased all settings off that Added single create method to KernelBaseSettings: - sets model_config.env_prefix to cls.end_prefix allowing us to set the env_prefix as a classvar on each subclass and it works - if env_file_path is set, set that in model_config - strip all None values out of inputted values, then instantiate This also allows us to pass the settings that are supplied to the settings class, for overriding env settings. <!-- Describe your changes, the overall approach, the underlying design. These notes will help understanding how your code works. Thanks! --> ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [x] The code builds clean without any errors or warnings - [x] The PR follows the [SK Contribution Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts) raises no violations - [x] All unit tests pass, and I have added new tests where possible - [x] I didn't break anyone 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
The initial implementation of Pydantic Settings was not optimal yet, more optimized now.
Description
Added a KernelBaseSettings class in kernel_pydantic
Rebased all settings off that
Added single create method to KernelBaseSettings:
This also allows us to pass the settings that are supplied to the settings class, for overriding env settings.
Contribution Checklist