.Net: Fix for RestApiOperation.BuildQueryString #6662
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
changed the title
markwallace-microsoft
force-pushed
the
users/markwallace/build_query_string
branch
from
8fccaac
to
c6dc730
Compare
markwallace-microsoft
force-pushed
the
users/markwallace/build_query_string
branch
from
5951beb
to
ce435dc
Compare
markwallace-microsoft
force-pushed
the
users/markwallace/build_query_string
branch
from
0913ae6
to
dceb0cc
Compare
dmytrostruk
approved these changes
Jun 11, 2024
dotnet/src/Functions/Functions.OpenApi/Serialization/FormStyleParameterSerializer.cs
Show resolved
Hide resolved
westey-m
approved these changes
Jun 11, 2024
SergeyMenshykh
approved these changes
Jun 11, 2024
LudoCorporateShark
pushed a commit
to LudoCorporateShark/semantic-kernel
that referenced
this pull request
Aug 25, 2024
### Motivation and Context
We have noticed few cases where API calls were failing. Sample response:
"errors":{"since_create_time":["The value
'2024-05-01T00:00:00\u002B00:00' is not
valid."],"before_create_time":["The value
'2024-05-31T23:59:59\u002B00:00' is not valid."]}}
We are passing the value correctly to SK as 2024-05-01T00:00:00+00:00
but then it’s getting transformed to '2024-05-01T00:00:00\u002B00:00 in
[this code
here](https://github.com/microsoft/semantic-kernel/blob/275de5f08143172c1313f0e4da7a9eee4465a42a/dotnet/src/Functions/Functions.OpenApi/Serialization/OpenApiTypeConverter.cs#L30).
Then in this particular API these arguments are passed in the URL. The
final URL is this:
/campaigns?before_create_time=2024-05-31T23%3a59%3a59%5cu002B00%3a00&since_create_time=2024-05-01T00%3a00%3a00%5cu002B00%3a00
Now, I believe the problem is that everything would work just fine if
these values were passed as the request payload to the API, where API
would deserialize it correctly. But, since these are passed in URL, the
value is never deserialized and stays broken.
### Description
<!-- Describe your changes, the overall approach, the underlying design.
These notes will help understanding how your code works. Thanks! -->
### Contribution Checklist
<!-- Before submitting this PR, please make sure: -->
- [ ] The code builds clean without any errors or warnings
- [ ] The PR follows the [SK Contribution
Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md)
and the [pre-submission formatting
script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts)
raises no violations
- [ ] All unit tests pass, and I have added new tests where possible
- [ ] I didn't break anyone 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
We have noticed few cases where API calls were failing. Sample response:
"errors":{"since_create_time":["The value '2024-05-01T00:00:00\u002B00:00' is not valid."],"before_create_time":["The value '2024-05-31T23:59:59\u002B00:00' is not valid."]}}
We are passing the value correctly to SK as 2024-05-01T00:00:00+00:00 but then it’s getting transformed to '2024-05-01T00:00:00\u002B00:00 in this code here.
Then in this particular API these arguments are passed in the URL. The final URL is this: /campaigns?before_create_time=2024-05-31T23%3a59%3a59%5cu002B00%3a00&since_create_time=2024-05-01T00%3a00%3a00%5cu002B00%3a00
Now, I believe the problem is that everything would work just fine if these values were passed as the request payload to the API, where API would deserialize it correctly. But, since these are passed in URL, the value is never deserialized and stays broken.
Description
Contribution Checklist