.Net: Align the behavior of the ChatMessageContent.Content property setter with streaming counterpart #6753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tter with the behavior of the StreamingChatMessageContent.Content one.
markwallace-microsoft
added
kernel
dmytrostruk
approved these changes
Jun 17, 2024
RogerBarreto
approved these changes
Jun 18, 2024
LudoCorporateShark
pushed a commit
to LudoCorporateShark/semantic-kernel
that referenced
this pull request
Aug 25, 2024
…etter with streaming counterpart (microsoft#6753) ### Motivation and Context This is a follow-up fix for the `ChatMessageContent.Content` property setter, similar to the one that was done to the `StreamingChatMessageContent.Content` property when addressing the PR comment: microsoft#6449 (comment). ### Description This change updates the text of the first text item regardless of the value being set. This helps avoid inconsistency that occurs when text content already exists in the items collection, null is set via the Content property, and the setter does nothing, while the getter returns the text message content: ```csharp var items = new ChatMessageContentItemCollection { new TextContent("Hi AI."), }; var chatMessage = new ChatMessageContent(AuthorRole.User, items: items); chatMessage.Content = null; // The property setter does nothing if the value is null. // Fails Assert.Null(chatMessage.Content); // The property getter returns the "Hi AI." text. ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
This is a follow-up fix for the
ChatMessageContent.Contentproperty setter, similar to the one that was done to theStreamingChatMessageContent.Contentproperty when addressing the PR comment: #6449 (comment).Description
This change updates the text of the first text item regardless of the value being set. This helps avoid inconsistency that occurs when text content already exists in the items collection, null is set via the Content property, and the setter does nothing, while the getter returns the text message content: