Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for weaviate as a memory store (Python) #804

Merged
merged 70 commits into from
Jun 5, 2023
Merged

Add support for weaviate as a memory store (Python) #804

merged 70 commits into from
Jun 5, 2023

Conversation

hsm207
Copy link
Contributor

@hsm207 hsm207 commented May 4, 2023

Motivation and Context

  1. Why is this change required?
    Add support for weaviate as a memory store
  2. What problem does it solve?
    People want to use weaviate as a memory store
  3. What scenario does it contribute to?
    See point 2
  4. If it fixes an open issue, please link to the issue here.
    Add support for weaviate as a memory store (Python) #803

Description

Implement MemoryStoreBase for weaviate

Contribution Checklist

hsm207 added 16 commits May 3, 2023 10:39
@hsm207
Python: Support embedded weaviate
09518db 
Signed-off-by: hsm207 <hsm207@users.noreply.github.com>
@hsm207
Python: Implement create collection
7d42649 
Signed-off-by: hsm207 <hsm207@users.noreply.github.com>
@hsm207
Python: Reformat code
34b68e8 
Signed-off-by: hsm207 <hsm207@users.noreply.github.com>
@hsm207
Python: Implement get collections
7c094b3 
Signed-off-by: hsm207 <hsm207@users.noreply.github.com>
@hsm207
Python: Implement delete collection
a36cc10 
Signed-off-by: hsm207 <hsm207@users.noreply.github.com>
@hsm207
Python: Implement collection exists
eb11ae6 
Signed-off-by: hsm207 <hsm207@users.noreply.github.com>
@hsm207
Python: Refactor tests
f185f29 
Signed-off-by: hsm207 <hsm207@users.noreply.github.com>
@hsm207
Python: Implement upsert
6367e92 
Signed-off-by: hsm207 <hsm207@users.noreply.github.com>
@hsm207
Python: Refactor tests
deb7ce1 
Signed-off-by: hsm207 <hsm207@users.noreply.github.com>
@hsm207
Python: Implement get
a22cc19 
Signed-off-by: hsm207 <hsm207@users.noreply.github.com>
@hsm207
Merge branch 'main' of https://github.com/microsoft/semantic-kernel i…
f35f45f 
…nto memory-store-weaviate
@hsm207
Python: Implement remove
9254973 
Signed-off-by: hsm207 <hsm207@users.noreply.github.com>
@hsm207
Python: Implement nearest match
34de500 
Signed-off-by: hsm207 <hsm207@users.noreply.github.com>
@hsm207
Merge branch 'main' of https://github.com/microsoft/semantic-kernel i…
be29b3e 
…nto memory-store-weaviate
@hsm207
Python: Implement get nearest match
6f2eb9a 
Signed-off-by: hsm207 <hsm207@users.noreply.github.com>
@hsm207
Python: Fix typo
205fe35 
Signed-off-by: hsm207 <hsm207@users.noreply.github.com>
@github-actions github-actions bot added the python Pull requests for the Python Semantic Kernel label May 4, 2023
@hsm207
Copy link
Contributor Author

hsm207 commented May 8, 2023

@awharrison-28 @tawalke how's the review going?

@tawalke
Copy link
Contributor

tawalke commented May 8, 2023 •
edited
Loading

@awharrison-28 @tawalke how's the review going?

Hi @hsm207 thanks for checking in, it is in progress.

Would you mind ensuring the branch is updated with changes from main branch and updated code as needed. Thanks!

@tawalke
Copy link
Contributor

tawalke commented May 9, 2023 •
edited
Loading

@hsm207 Thanks for updating, will provide more feedback as I test calls to Weaviate service shortly.

awharrison-28
awharrison-28 previously approved these changes May 22, 2023
View reviewed changes
Copy link
Contributor

@awharrison-28 awharrison-28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Modified the test skip code - verified locally that if the platform is windows, integration tests for weaviate memory store are skipped.

awharrison-28
awharrison-28 reviewed May 22, 2023
View reviewed changes
FEATURE_MATRIX.md Outdated Show resolved Hide resolved
awharrison-28
awharrison-28 previously approved these changes May 22, 2023
View reviewed changes
@awharrison-28
Copy link
Contributor

@hsm207 please run and commit poetry lock - this will account for the downstream dependencies of the weaviate client package.

@hsm207
Python: run poetry lock
9eae328 
Signed-off-by: hsm207 <hsm207@users.noreply.github.com>
@hsm207
Merge branch 'main' into memory-store-weaviate
ec87677
@hsm207
Copy link
Contributor Author

hsm207 commented Jun 3, 2023

@tawalke could you review this PR please?

@dluc dluc merged commit 18cd0cd into microsoft:main Jun 5, 2023
@hsm207 hsm207 deleted the memory-store-weaviate branch June 5, 2023 16:40
@dluc dluc mentioned this pull request Jun 9, 2023
Closed
shawncal pushed a commit to shawncal/semantic-kernel that referenced this pull request Jul 6, 2023
@hsm207 @awharrison-28 @dluc
Add support for weaviate as a memory store (Python) (microsoft#804)
91b64eb 
Add support for weaviate as a memory store
see microsoft#803

Co-authored-by: Abby Harrison <54643756+awharrison-28@users.noreply.github.com>
Co-authored-by: Devis Lucato <dluc@users.noreply.github.com>
Co-authored-by: Abby Harrison <abby.harrison@microsoft.com>
johnoliver pushed a commit to johnoliver/semantic-kernel that referenced this pull request Jun 5, 2024
@hsm207 @awharrison-28 @dluc
Add support for weaviate as a memory store (Python) (microsoft#804)
d4a0324 
Add support for weaviate as a memory store
see microsoft#803

Co-authored-by: Abby Harrison <54643756+awharrison-28@users.noreply.github.com>
Co-authored-by: Devis Lucato <dluc@users.noreply.github.com>
Co-authored-by: Abby Harrison <abby.harrison@microsoft.com>
johnoliver pushed a commit to johnoliver/semantic-kernel that referenced this pull request Jun 5, 2024
@hsm207 @awharrison-28 @dluc
Add support for weaviate as a memory store (Python) (microsoft#804)
998268b 
Add support for weaviate as a memory store
see microsoft#803

Co-authored-by: Abby Harrison <54643756+awharrison-28@users.noreply.github.com>
Co-authored-by: Devis Lucato <dluc@users.noreply.github.com>
Co-authored-by: Abby Harrison <abby.harrison@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lemillermicrosoft lemillermicrosoft lemillermicrosoft left review comments

@dluc dluc dluc left review comments

@awharrison-28 awharrison-28 awharrison-28 approved these changes

@tawalke tawalke Awaiting requested review from tawalke

Assignees

@awharrison-28 awharrison-28

Labels
python Pull requests for the Python Semantic Kernel
Projects
No open projects
Python Semantic Kernel
Status: Released
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@hsm207 @tawalke @awharrison-28 @dluc @lemillermicrosoft