Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed build issues #315

Merged
merged 2 commits into from
Apr 14, 2017
Merged

fixed build issues #315

merged 2 commits into from
Apr 14, 2017

Conversation

llali
Copy link
Member

@llali llali commented Apr 14, 2017

No description provided.

@msftclas
Copy link

@llali,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

build.cake Outdated
if(!System.IO.Directory.Exists(inputXliff))
{
System.IO.Directory.CreateDirectory(inputXliff);
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: spaces not tabs

build.cake Outdated
@@ -551,6 +551,11 @@ Task("SRGen")
System.IO.File.Delete(outputCs);
}

if(!System.IO.Directory.Exists(inputXliff))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

( [](start = 4, length = 1)

nit: space after this if

@pensivebrian
Copy link
Member

:shipit:

@coveralls
Copy link

Coverage Status

Coverage increased (+4.7%) to 81.037% when pulling 07e2364 on fix/buildIssues into 6daadcf on dev.

@llali llali merged commit 88eb0f6 into dev Apr 14, 2017
@coveralls
Copy link

Coverage Status

Coverage decreased (-4.5%) to 71.775% when pulling 07e2364 on fix/buildIssues into 6daadcf on dev.

@llali llali deleted the fix/buildIssues branch April 18, 2017 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants