Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix serialization tests & don't block thread #846

Merged
merged 4 commits into from
Aug 9, 2019
Merged

Fix serialization tests & don't block thread #846

merged 4 commits into from
Aug 9, 2019

Commits on Aug 8, 2019

  1. Fix serialization tests & don't block thread 

    - Fixed potential null ref when closing streams
- Always clean up serialization queue if an error occurs
- Stop blocking dispatcher thread by not awaiting task that processes the message
- Improved error logging in EventFlowValidator to help debug issues

My hope is this will result in the tests reliably passing now.
Will monitor in GCI to verify
    @kevcunnane
    kevcunnane committed Aug 8, 2019
    Configuration menu
    Copy the full SHA
    9b9297b View commit details
    Browse the repository at this point in the history

  2. Close stream on exception

    @kevcunnane
    kevcunnane committed Aug 8, 2019
    Configuration menu
    Copy the full SHA
    d84ce9e View commit details
    Browse the repository at this point in the history

  3. Use string interpolation

    @kevcunnane
    kevcunnane committed Aug 8, 2019
    Configuration menu
    Copy the full SHA
    b98c51b View commit details
    Browse the repository at this point in the history

  4. Add missing )

    @kevcunnane
    kevcunnane committed Aug 8, 2019
    Configuration menu
    Copy the full SHA
    3334215 View commit details
    Browse the repository at this point in the history