Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update DacFx and MDS to same version #986

Merged
merged 2 commits into from
Jun 22, 2020
Merged

Conversation

udeeshagautam
Copy link
Contributor

Update DacFx and MDS to same version. Fixing a test (unrelated).

<PackageReference Update="Microsoft.SqlServer.SqlManagementObjects" Version="160.2004021.0" />
<PackageReference Update="Microsoft.SqlServer.DACFx" Version="150.4787.1-preview" GeneratePathProperty="true" />
<PackageReference Update="Microsoft.SqlServer.DACFx" Version="150.4822.1-preview" GeneratePathProperty="true" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does the DacFx version being listed as a preview mean? Just that it's not a version that went through the full release process for https://www.microsoft.com/en-us/download/details.aspx?id=55114?

Copy link
Contributor Author

@udeeshagautam udeeshagautam Jun 22, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, they can have additional changes than the last released version. The nugets used are from here : https://www.nuget.org/packages/Microsoft.SqlServer.DACFx

@udeeshagautam udeeshagautam merged commit 3049dac into main Jun 22, 2020
@udeeshagautam udeeshagautam deleted the feature/updateDacFx branch June 22, 2020 22:17
nofield pushed a commit that referenced this pull request Jul 19, 2022
* Updating DacFx and MDS nuget to match versions

* Fixing a test. It's unreleated to change.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants