Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Monitor: Integration - Integrate monitor into Superbench #259

Merged
merged 14 commits into from
Dec 10, 2021

Conversation

guoshzhao
Copy link
Contributor

Description
Integrate monitor into Superbench.

Major Revision

  • Initialize, start and stop monitor in SB executor.
  • Parse the monitor data in SB runner and merge into benchmark results.
  • Specify ReduceType for monitor metrics, such as MAX, MIN and LAST.
  • Add monitor configs into config file.

superbench/benchmarks/reducer.py Show resolved Hide resolved
superbench/executor/executor.py Show resolved Hide resolved
superbench/executor/executor.py Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Dec 8, 2021

Codecov Report

Merging #259 (2421528) into main (afea991) will decrease coverage by 0.10%.
The diff coverage is 79.31%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #259      +/-   ##
==========================================
- Coverage   88.11%   88.00%   -0.11%     
==========================================
  Files          71       71              
  Lines        3996     4045      +49     
==========================================
+ Hits         3521     3560      +39     
- Misses        475      485      +10     
Flag Coverage Δ
cpu-unit-test 72.83% <77.19%> (+0.07%) ⬆️
cuda-unit-test 87.96% <79.31%> (-0.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superbench/executor/executor.py 75.63% <61.11%> (-2.68%) ⬇️
superbench/monitor/monitor.py 64.62% <66.66%> (ø)
superbench/benchmarks/reducer.py 93.93% <85.71%> (-2.22%) ⬇️
superbench/runner/runner.py 86.71% <89.28%> (+0.50%) ⬆️
superbench/monitor/record.py 97.50% <100.00%> (+0.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update afea991...2421528. Read the comment docs.

docs/superbench-config.mdx Outdated Show resolved Hide resolved
docs/superbench-config.mdx Outdated Show resolved Hide resolved
docs/superbench-config.mdx Outdated Show resolved Hide resolved
docs/superbench-config.mdx Outdated Show resolved Hide resolved
Comment on lines 210 to 211
else:
logger.warning('Monitor can not support ROCM platform.')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

else includes Platform.CPU? do you want to monitor cpu and network because only gpu metrics won't work?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated the log message.

@abuccts abuccts enabled auto-merge (squash) December 10, 2021 09:16
@abuccts abuccts merged commit 6e357fb into main Dec 10, 2021
@abuccts abuccts deleted the guzhao/call_monitor branch December 10, 2021 09:33
@cp5555 cp5555 mentioned this pull request Dec 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants