-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Monitor: Integration - Integrate monitor into Superbench #259
Conversation
Codecov Report
@@ Coverage Diff @@
## main #259 +/- ##
==========================================
- Coverage 88.11% 88.00% -0.11%
==========================================
Files 71 71
Lines 3996 4045 +49
==========================================
+ Hits 3521 3560 +39
- Misses 475 485 +10
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
…mark into guzhao/call_monitor
superbench/executor/executor.py
Outdated
else: | ||
logger.warning('Monitor can not support ROCM platform.') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
else includes Platform.CPU? do you want to monitor cpu and network because only gpu metrics won't work?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated the log message.
Description
Integrate monitor into Superbench.
Major Revision