-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Benchmarks: Add Feature - Add GPU-Burn as microbenchmark #324
Conversation
@rafsalas19 Thanks a lot for the PR! Overall it looks good to me. I have some general comments:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pls run python3 setup.py lint
to check lint issues, python3 setup.py format
may help fix part of lint issues automatically.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pls run python3 setup.py format
and commit changes to pass the pipeline.
Codecov Report
@@ Coverage Diff @@
## main #324 +/- ##
==========================================
- Coverage 88.78% 88.61% -0.17%
==========================================
Files 77 78 +1
Lines 4593 4665 +72
==========================================
+ Hits 4078 4134 +56
- Misses 515 531 +16
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Description
Modifications adding GPU-Burn to SuperBench.