Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Analyzer: Add Feature - Output results of all nodes in data diagnosis #336

Merged
merged 7 commits into from
Apr 10, 2022

Conversation

yukirora
Copy link
Contributor

@yukirora yukirora commented Apr 6, 2022

Description
Output results of all nodes in data diagnosis.

@yukirora yukirora added the tool label Apr 6, 2022
@yukirora yukirora requested a review from a team as a code owner April 6, 2022 03:32
@codecov
Copy link

codecov bot commented Apr 6, 2022

Codecov Report

Merging #336 (4c3ae55) into main (56c9a71) will increase coverage by 0.03%.
The diff coverage is 94.87%.

@@            Coverage Diff             @@
##             main     #336      +/-   ##
==========================================
+ Coverage   88.85%   88.89%   +0.03%     
==========================================
  Files          80       80              
  Lines        4926     4961      +35     
==========================================
+ Hits         4377     4410      +33     
- Misses        549      551       +2     
Flag Coverage Δ
cpu-unit-test 74.46% <94.87%> (+0.14%) ⬆️
cuda-unit-test 88.83% <94.87%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superbench/analyzer/data_diagnosis.py 88.53% <94.87%> (+1.10%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 56c9a71...4c3ae55. Read the comment docs.

Copy link
Member

@abuccts abuccts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls remove .DS_Store

@cp5555 cp5555 mentioned this pull request Apr 8, 2022
@yukirora
Copy link
Contributor Author

pls remove .DS_Store

updated, thanks

@cp5555 cp5555 merged commit 55b0f9d into main Apr 10, 2022
@cp5555 cp5555 deleted the v-yutji/diagnosis-internel-support branch April 10, 2022 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants