Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade colorlog for NO_COLOR support #404

Merged
merged 1 commit into from
Aug 31, 2022
Merged

Conversation

abuccts
Copy link
Member

@abuccts abuccts commented Aug 31, 2022

Upgrade colorlog for $NO_COLOR support.

Upgrade colorlog for [`$NO_COLOR`](https://no-color.org/) support.
@abuccts abuccts added enhancement New feature or request utils SuperBench utilities dependencies Pull requests that update a dependency file labels Aug 31, 2022
@abuccts abuccts requested a review from a team as a code owner August 31, 2022 04:40
@codecov
Copy link

codecov bot commented Aug 31, 2022

Codecov Report

Merging #404 (7cf5aab) into release/0.6 (b5e3678) will decrease coverage by 0.00%.
The diff coverage is 80.00%.

@@               Coverage Diff               @@
##           release/0.6     #404      +/-   ##
===============================================
- Coverage        88.66%   88.65%   -0.01%     
===============================================
  Files               83       83              
  Lines             5268     5273       +5     
===============================================
+ Hits              4671     4675       +4     
- Misses             597      598       +1     
Flag Coverage Δ
cpu-python3.6-unit-test 75.13% <80.00%> (+<0.01%) ⬆️
cpu-python3.7-unit-test 75.13% <80.00%> (+<0.01%) ⬆️
cuda-unit-test 88.58% <80.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superbench/common/utils/logging.py 97.05% <80.00%> (-2.95%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@cp5555 cp5555 linked an issue Aug 31, 2022 that may be closed by this pull request
@abuccts abuccts enabled auto-merge (squash) August 31, 2022 05:37
@cp5555 cp5555 mentioned this pull request Aug 31, 2022
27 tasks
@abuccts abuccts merged commit 34202d4 into release/0.6 Aug 31, 2022
@abuccts abuccts deleted the xiongyf/update-colorlog branch August 31, 2022 05:51
@yukirora yukirora mentioned this pull request Sep 5, 2022
27 tasks
abuccts added a commit that referenced this pull request Sep 6, 2022
Upgrade colorlog for [`$NO_COLOR`](https://no-color.org/) support.
abuccts added a commit that referenced this pull request Sep 6, 2022
**Description**

Cherry-pick bug fixes from v0.6.0 to main.

**Major Revisions**

* Enable latency test in ib traffic validation distributed benchmark (#396)
* Enhance parameter parsing to allow spaces in value (#397)
* Update apt packages in dockerfile (#398)
* Upgrade colorlog for NO_COLOR support (#404)
* Analyzer - Update error handling to support exit code of sb result diagnosis (#403)
* Analyzer - Make baseline file optional in data diagnosis and fix bugs (#399)
* Enhance timeout cleanup to avoid possible hanging (#405)
* Auto generate ibstat file by pssh (#402)
* Analyzer - Format int type and unify empty value to N/A in diagnosis output file (#406)
* Docs - Upgrade version and release note (#407)
* Docs - Fix issues in document (#408)

Co-authored-by: Yang Wang <yangwang1@microsoft.com>
Co-authored-by: Yuting Jiang <yutingjiang@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file enhancement New feature or request utils SuperBench utilities
Projects
None yet
Development

Successfully merging this pull request may close these issues.

superbench logging: 'color' output should be optional
3 participants