Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Samples cleanup]: Updated Code for Teams ToolKit "Create an AI Chatbot" template with Teams AI Library & Updated/More Samples #1250

Closed
8 of 10 tasks
Carter425 opened this issue Feb 6, 2024 · 0 comments · Fixed by #1529
Assignees
Labels
enhancement New feature or request epic samples work wrt samples

Comments

@Carter425
Copy link
Contributor

Carter425 commented Feb 6, 2024

Scenario

The "Create an AI Chatbot" template with Teams AI Library on the Teams Toolkit is out of date compared to the Teams AI Library newer code. For example, Teams Toolkit users still have to uncomment Azure OpenAI planner in index.ts prior to using Azure OpenAI Service with the Teams AI Library. This is an inconsistent and more complicated experience than the newer version of the Teams AI Library. Second, C# can be added as a language option to create an AI Chat Bot. Last, there can be more samples from the Teams AI Library on Teams Toolkit.

1 Pager Spec for additional details
https://microsoft-my.sharepoint.com/:w:/p/v-cgilliam/EQvZryU1xiJErTXNih07APIBOkiISejtMWlzOmfw_5YZrg?e=KbbNGN

David Rousset and Junjie Li created this bug on the Teams Toolkit side to track on their end https://msazure.visualstudio.com/Microsoft%20Teams%20Extensibility/_workitems/edit/26687860

Solution

Provide the updated code for the Teams AI Library to the Teams Toolkit team in JavaScript, Typescript, & #C in order to update the "Create an AI Chatbot" template in Teams Toolkit.

Additionally, assist in the coordination of sending over chosen samples to Teams Toolkit

Additional Context

Example of out of date code.
image

=====

@corinagum section

Tasks

  1. JS samples small
  2. 24 of 24
    JS samples
    corinagum therealjohn
  3. corinagum
  4. bug
    corinagum
  5. samples support answered
    corinagum
  6. bug
    corinagum
  7. bug large
    corinagum
@Carter425 Carter425 added the enhancement New feature or request label Feb 6, 2024
@corinagum corinagum self-assigned this Mar 27, 2024
@corinagum corinagum added the samples work wrt samples label Mar 27, 2024
@corinagum corinagum changed the title [Feature Request]: Updated Code for Teams ToolKit "Create an AI Chatbot" template with Teams AI Library & Updated/More Samples [Samples cleanup]: Updated Code for Teams ToolKit "Create an AI Chatbot" template with Teams AI Library & Updated/More Samples Mar 27, 2024
@corinagum corinagum added the epic label Mar 27, 2024
corinagum added a commit that referenced this issue Apr 2, 2024
…from Teams Toolkit gallery (#1458)

#minor
#1250 
## Details

Demonstrates how a sample can be updated so it runs directly with Teams
Toolkit when downloading it with the sample gallery instead of relying
on guidance when contributing to the repo.

The caveat to this approach is that it makes it slightly harder for
contributors to run by requiring them to change files on first run.
Since Teams Toolkit will point to samples directly in this repo, they
need to run as a folder outside the repo (no Yarn steps).

#### Change details

- Adds `npm install` step to the Teams Toolkit automation #1432 
- Adds defaults for the env files
- Updates docs / guidance
- Fixes icons to prevent validation errors
- Fixes infra files so provision and deploy to Azure works #1427 

This does work around #1405 by specifying `"openai": "4.28.4"` in the
package.json.

---------

Co-authored-by: Corina <14900841+corinagum@users.noreply.github.com>
corinagum added a commit that referenced this issue Apr 2, 2024
#1481)

## Linked issues

#minor
related to #1250

## Details

- Update location of MessageExtension samples to inside teams-features
directory
- Update ME sample README file to include directions for using npm with
ttk
- Update Samples.md for relocated sample
- Make botbuilder and openai peer dependencies in teams-ai
- Fix llama sample to include log samples in client creation
- Update TTK yml files to use npm


## Attestation Checklist

- [x] My code follows the style guidelines of this project

- I have checked for/fixed spelling, linting, and other errors
- I have commented my code for clarity
- I have made corresponding changes to the documentation (updating the
doc strings in the code is sufficient)
- My changes generate no new warnings
- I have added tests that validates my changes, and provides sufficient
test coverage. I have tested with:
  - Local testing
  - E2E testing in Teams
- New and existing unit tests pass locally with my changes

### Additional information

> Feel free to add other relevant information below

---------

Co-authored-by: Corina Gum <>
corinagum added a commit that referenced this issue Apr 2, 2024
## Linked issues

#minor
related to #1250 

## Details
- Move sample to `teams-features` directory
- Update TTK to use npm instead of yarn
- Update related documentation 
- Update Samples.md for relocated sample
#### Change details

> Describe your changes, with screenshots and code snippets as
appropriate

## Attestation Checklist

- [x] My code follows the style guidelines of this project

- I have checked for/fixed spelling, linting, and other errors
- I have commented my code for clarity
- I have made corresponding changes to the documentation (updating the
doc strings in the code is sufficient)
- My changes generate no new warnings
- I have added tests that validates my changes, and provides sufficient
test coverage. I have tested with:
  - Local testing
  - E2E testing in Teams
- New and existing unit tests pass locally with my changes

### Additional information

> Feel free to add other relevant information below

Co-authored-by: Corina Gum <>
corinagum added a commit that referenced this issue Apr 3, 2024
)

## Linked issues

#minor
related to #1250 

## Details

- Move twenty questions sample to ai-concepts section
- Update TTK files and update README for using TTK with npm
- Minor updates to other sample readmes
- Update link to SAMPLES.md

## Attestation Checklist

- [x] My code follows the style guidelines of this project

- I have checked for/fixed spelling, linting, and other errors
- I have commented my code for clarity
- I have made corresponding changes to the documentation (updating the
doc strings in the code is sufficient)
- My changes generate no new warnings
- I have added tests that validates my changes, and provides sufficient
test coverage. I have tested with:
  - Local testing
  - E2E testing in Teams
- New and existing unit tests pass locally with my changes

---------

Co-authored-by: Corina Gum <>
corinagum added a commit that referenced this issue Apr 8, 2024
#1500)

## Linked issues

closes: #minor
related to #1250

## Details

Move AI Message extensions sample to ai-concepts section
Update TTK files and update README for using TTK with npm
Minor updates to other sample readmes
Update link to SAMPLES.md

#### Change details

> Describe your changes, with screenshots and code snippets as
appropriate

**code snippets**:

**screenshots**:

## Attestation Checklist

- [x] My code follows the style guidelines of this project

- I have checked for/fixed spelling, linting, and other errors
- I have commented my code for clarity
- I have made corresponding changes to the documentation (updating the
doc strings in the code is sufficient)
- My changes generate no new warnings
- I have added tests that validates my changes, and provides sufficient
test coverage. I have tested with:
  - Local testing
  - E2E testing in Teams
- New and existing unit tests pass locally with my changes

### Additional information

> Feel free to add other relevant information below

---------

Co-authored-by: Corina Gum <>
corinagum added a commit that referenced this issue Apr 10, 2024
## Linked issues

#minor
related: #1250
related: #1461

## Details

- Move Mathbot to ai-apps folder
- Fix TTK files to match chef bot

#### Change details

> Describe your changes, with screenshots and code snippets as
appropriate

**code snippets**:

**screenshots**:

## Attestation Checklist

- [x] My code follows the style guidelines of this project

- I have checked for/fixed spelling, linting, and other errors
- I have commented my code for clarity
- I have made corresponding changes to the documentation (updating the
doc strings in the code is sufficient)
- My changes generate no new warnings
- I have added tests that validates my changes, and provides sufficient
test coverage. I have tested with:
  - Local testing
  - E2E testing in Teams
- New and existing unit tests pass locally with my changes

### Additional information

> Feel free to add other relevant information below

---------

Co-authored-by: Corina Gum <>
corinagum added a commit that referenced this issue Apr 10, 2024
## Linked issues

#minor
related: #1250
related: #1461

## Details
- Move OrderBot to ai-apps folder
- Fix TTK files 
- Update dependencies

## Attestation Checklist

- [x] My code follows the style guidelines of this project

- I have checked for/fixed spelling, linting, and other errors
- I have commented my code for clarity
- I have made corresponding changes to the documentation (updating the
doc strings in the code is sufficient)
- My changes generate no new warnings
- I have added tests that validates my changes, and provides sufficient
test coverage. I have tested with:
  - Local testing
  - E2E testing in Teams
- New and existing unit tests pass locally with my changes

### Additional information

> Feel free to add other relevant information below

Co-authored-by: Corina Gum <>
corinagum added a commit that referenced this issue Apr 10, 2024
…cepts folder (#1510)

## Linked issues

closes: #1509 
related: #1250
related: #1461

## Details

- Add ability to log requests to Llama Model
- Move Llama sample to ai-concepts folder
- Update TTK files 
- Update `teamsapp.testtool.yml` files to remove unnecessary variable

## Attestation Checklist

- [x] My code follows the style guidelines of this project

- I have checked for/fixed spelling, linting, and other errors
- I have commented my code for clarity
- I have made corresponding changes to the documentation (updating the
doc strings in the code is sufficient)
- My changes generate no new warnings
- I have added tests that validates my changes, and provides sufficient
test coverage. I have tested with:
  - Local testing
  - E2E testing in Teams
- New and existing unit tests pass locally with my changes

### Additional information

> Feel free to add other relevant information below

---------

Co-authored-by: Corina Gum <>
corinagum added a commit that referenced this issue Apr 10, 2024
## Linked issues
#minor
related: #1250
related: #1461

## Details

- Move Devops sample to ai-apps folder
- Update TTK files to match teams chefbot

## Attestation Checklist

- [x] My code follows the style guidelines of this project

- I have checked for/fixed spelling, linting, and other errors
- I have commented my code for clarity
- I have made corresponding changes to the documentation (updating the
doc strings in the code is sufficient)
- My changes generate no new warnings
- I have added tests that validates my changes, and provides sufficient
test coverage. I have tested with:
  - Local testing
  - E2E testing in Teams
- New and existing unit tests pass locally with my changes

### Additional information

> Feel free to add other relevant information below

---------

Co-authored-by: Corina Gum <>
corinagum added a commit that referenced this issue Apr 10, 2024
## Linked issues

#minor
related: #1250
related: #1461

## Details

Provide a list of your changes here. If you are fixing a bug, please
provide steps to reproduce the bug.
- Move Whobot to ai-apps folder
- Fix TTK files
- Update dependencies 

## Attestation Checklist

- [x] My code follows the style guidelines of this project

- I have checked for/fixed spelling, linting, and other errors
- I have commented my code for clarity
- I have made corresponding changes to the documentation (updating the
doc strings in the code is sufficient)
- My changes generate no new warnings
- I have added tests that validates my changes, and provides sufficient
test coverage. I have tested with:
  - Local testing
  - E2E testing in Teams
- New and existing unit tests pass locally with my changes

### Additional information

> Feel free to add other relevant information below

Co-authored-by: Corina Gum <>
corinagum added a commit that referenced this issue Apr 10, 2024
## Linked issues

#minor
related: #1250
related: #1461

## Details

- Move card gazer sample
- Update TTK files to match chef bot
- update repo url in package.json
- update packages in package.json


## Attestation Checklist

- [x] My code follows the style guidelines of this project

- I have checked for/fixed spelling, linting, and other errors
- I have commented my code for clarity
- I have made corresponding changes to the documentation (updating the
doc strings in the code is sufficient)
- My changes generate no new warnings
- I have added tests that validates my changes, and provides sufficient
test coverage. I have tested with:
  - Local testing
  - E2E testing in Teams
- New and existing unit tests pass locally with my changes

### Additional information

> Feel free to add other relevant information below

---------

Co-authored-by: Corina Gum <>
corinagum added a commit that referenced this issue Apr 10, 2024
## Linked issues

#minor
related to: #1250 
related: #1461

## Details

- Move LightBot sample to ai-concepts section
- Update TTK files and update README for using TTK with npm
- Update link to SAMPLES.md

#### Change details

> Describe your changes, with screenshots and code snippets as
appropriate

**code snippets**:

**screenshots**:

## Attestation Checklist

- [x] My code follows the style guidelines of this project

- I have checked for/fixed spelling, linting, and other errors
- I have commented my code for clarity
- I have made corresponding changes to the documentation (updating the
doc strings in the code is sufficient)
- My changes generate no new warnings
- I have added tests that validates my changes, and provides sufficient
test coverage. I have tested with:
  - Local testing
  - E2E testing in Teams
- New and existing unit tests pass locally with my changes

### Additional information

> Feel free to add other relevant information below

---------

Co-authored-by: Corina Gum <>
corinagum added a commit that referenced this issue Apr 10, 2024
## Linked issues

#minor
related to #1250
related: #1461

## Details

Move ListBot sample to ai-concepts section
Update TTK files and update README for using TTK with npm

## Attestation Checklist

- [x] My code follows the style guidelines of this project

- I have checked for/fixed spelling, linting, and other errors
- I have commented my code for clarity
- I have made corresponding changes to the documentation (updating the
doc strings in the code is sufficient)
- My changes generate no new warnings
- I have added tests that validates my changes, and provides sufficient
test coverage. I have tested with:
  - Local testing
  - E2E testing in Teams
- New and existing unit tests pass locally with my changes

### Additional information

> Feel free to add other relevant information below

Co-authored-by: Corina Gum <>
corinagum added a commit that referenced this issue Apr 11, 2024
## Linked issues

#minor
related: #1250 
related: #1461 

## Details

- Update `.gitattributes` to handle png's and jpg's as binary -- I think
this what caused our images to get corrupted
- Move AI Search sample to ai-apps
- Fix TTK files
- Update dependencies

## Attestation Checklist

- [x] My code follows the style guidelines of this project

- I have checked for/fixed spelling, linting, and other errors
- I have commented my code for clarity
- I have made corresponding changes to the documentation (updating the
doc strings in the code is sufficient)
- My changes generate no new warnings
- I have added tests that validates my changes, and provides sufficient
test coverage. I have tested with:
  - Local testing
  - E2E testing in Teams
- New and existing unit tests pass locally with my changes

---------

Co-authored-by: Corina Gum <>
corinagum added a commit that referenced this issue Apr 11, 2024
## Linked issues

#minor
related: #1250
related: #1461

## Details

- Move chat moderation sample
- Update repo link in a couple samples
- Update testtool env file 

## Attestation Checklist

- [x] My code follows the style guidelines of this project

- I have checked for/fixed spelling, linting, and other errors
- I have commented my code for clarity
- I have made corresponding changes to the documentation (updating the
doc strings in the code is sufficient)
- My changes generate no new warnings
- I have added tests that validates my changes, and provides sufficient
test coverage. I have tested with:
  - Local testing
  - E2E testing in Teams
- New and existing unit tests pass locally with my changes

### Additional information

> Feel free to add other relevant information below

---------

Co-authored-by: Corina Gum <>
corinagum added a commit that referenced this issue Apr 11, 2024
## Linked issues

#minor
related: #1250
related: #1461

## Details

- Move Teams Chef Bot

## Attestation Checklist

- [x] My code follows the style guidelines of this project

- I have checked for/fixed spelling, linting, and other errors
- I have commented my code for clarity
- I have made corresponding changes to the documentation (updating the
doc strings in the code is sufficient)
- My changes generate no new warnings
- I have added tests that validates my changes, and provides sufficient
test coverage. I have tested with:
  - Local testing
  - E2E testing in Teams
- New and existing unit tests pass locally with my changes

### Additional information

> Feel free to add other relevant information below

---------

Co-authored-by: Corina Gum <>
corinagum added a commit that referenced this issue Apr 11, 2024
## Linked issues

#minor
related: #1250
related: #1461 

## Details

- Move datasource Azure OpenAI sample to ai-apps
- Fix TTK files
- Update dependencies

## Attestation Checklist

- [x] My code follows the style guidelines of this project

- I have checked for/fixed spelling, linting, and other errors
- I have commented my code for clarity
- I have made corresponding changes to the documentation (updating the
doc strings in the code is sufficient)
- My changes generate no new warnings
- I have added tests that validates my changes, and provides sufficient
test coverage. I have tested with:
  - Local testing
  - E2E testing in Teams
- New and existing unit tests pass locally with my changes

Co-authored-by: Corina Gum <>
corinagum added a commit that referenced this issue Apr 16, 2024
## Linked issues

#minor
related: #1250 
related: #1461

## Details

- Move all auth samples
- Ensure TTK files have npm install
- Update dependencies

- [x] My code follows the style guidelines of this project

- I have checked for/fixed spelling, linting, and other errors
- I have commented my code for clarity
- I have made corresponding changes to the documentation (updating the
doc strings in the code is sufficient)
- My changes generate no new warnings
- I have added tests that validates my changes, and provides sufficient
test coverage. I have tested with:
  - Local testing
  - E2E testing in Teams
- New and existing unit tests pass locally with my changes

### Additional information

> Feel free to add other relevant information below

---------

Co-authored-by: Corina Gum <>
corinagum added a commit that referenced this issue Apr 17, 2024
## Linked issues

fixes: #1250
fixes: #1461

## Details

- Update the links to the JS samples in SAMPLES.md
- Update package.json files to be normalized


## Attestation Checklist

- [x] My code follows the style guidelines of this project

- I have checked for/fixed spelling, linting, and other errors
- I have commented my code for clarity
- I have made corresponding changes to the documentation (updating the
doc strings in the code is sufficient)
- My changes generate no new warnings
- I have added tests that validates my changes, and provides sufficient
test coverage. I have tested with:
  - Local testing
  - E2E testing in Teams
- New and existing unit tests pass locally with my changes

### Additional information

> Feel free to add other relevant information below

---------

Co-authored-by: Corina Gum <>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request epic samples work wrt samples
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants