Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PY] feat: deploy echo bot to azure #1310

Merged
merged 10 commits into from
Feb 26, 2024
Merged

Conversation

blackchoey
Copy link
Contributor

@blackchoey blackchoey commented Feb 20, 2024

Linked issues

closes: #1254

Details

  1. Add configuration to allow users deploy the sample to Azure
  2. Use Flask instead of FastAPI, which is easier to be hosted using Azure App Service
  3. Adjust Teams Toolkit configuration to follow Python extension team's recommended experience
  4. Remove unused Attach to Local Service config in launch.json

Note: remote deploy requires Teams-AI being published to PYPI. I have manually tested the deploy configuration with a private Teams-AI package locally.

Attestation Checklist

  • My code follows the style guidelines of this project

  • I have checked for/fixed spelling, linting, and other errors

  • I have commented my code for clarity

  • I have made corresponding changes to the documentation (updating the doc strings in the code is sufficient)

  • My changes generate no new warnings

  • I have added tests that validates my changes, and provides sufficient test coverage. I have tested with:

    • Local testing
    • E2E testing in Teams
  • New and existing unit tests pass locally with my changes

TODO item:

Update pyproject.toml when we publish the Python package to PYPI

Copy link
Collaborator

@aacebo aacebo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think its best to keep using poetry for all the benefits it gives us as well as consistency, poetry even has a command for generating requirements.txt for situations like this, it is

poetry export --without-hashes --format=requirements.txt > requirements.txt

@aacebo aacebo merged commit 63ad30e into PYTHON Feb 26, 2024
10 of 11 checks passed
@aacebo aacebo deleted the chyuan/deploy-echo-bot-to-azure branch February 26, 2024 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants