Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PY] feat: OAI AssistantsPlanner and MathBot #1453

Merged
merged 12 commits into from
Mar 28, 2024
Merged

[PY] feat: OAI AssistantsPlanner and MathBot #1453

merged 12 commits into from
Mar 28, 2024

Conversation

lilyydu
Copy link
Contributor

@lilyydu lilyydu commented Mar 25, 2024 •
edited
Loading

Linked issues

closes: #1326 and #1252

Details

  • With reference to JS, implemented support for AssistantsPlanner with OAI and MathBot sample
  • updated Usage class typing for tests
  • will be adding tests in another PR (plan to add it for all our Planners at once)

Compared to JS:

  • returning an empty Plan in submit_user_input and submit_action_results
  • removed smaller methods that only had single API call

@aacebo
Copy link
Collaborator

aacebo commented Mar 27, 2024

you should run poetry run fmt to run the code formatter

@corinagum corinagum merged commit a25260a into main Mar 28, 2024
18 of 22 checks passed
@corinagum corinagum deleted the lilyydu/assistants-planner branch March 28, 2024 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aacebo aacebo aacebo approved these changes

@blackchoey blackchoey Awaiting requested review from blackchoey

@corinagum corinagum Awaiting requested review from corinagum corinagum is a code owner

@singhk97 singhk97 Awaiting requested review from singhk97 singhk97 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[PY] Assistants Planner
3 participants
@lilyydu @aacebo @corinagum