Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ghostly cursor droppings in OpenConsole #17310

Closed
j4james opened this issue May 23, 2024 · 2 comments · Fixed by #17332
Closed

Ghostly cursor droppings in OpenConsole #17310

j4james opened this issue May 23, 2024 · 2 comments · Fixed by #17332
Labels
In-PR This issue has a related PR Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting

Comments

@j4james
Copy link
Collaborator

j4james commented May 23, 2024

Windows Terminal version

Commit e826203

Windows build number

10.0.19045.4412

Other Software

No response

Steps to reproduce

  1. Build a recent commit of OpenConsole.
  2. Start a cmd shell.
  3. Set the cursor shape to Solid Block so it's easy to see.
  4. Hold down Enter and let the viewport scroll for a while.

Expected Behavior

You should only see the cursor on the last prompt of the page.

Actual Behavior

After a short while, you'll start to see a trail of ghostly cursor droppings left behind on most of the lines. They don't look like the full cursor droppings we've had in the past though - they seem to be about 25% of the usual brightness.

image
@j4james j4james added Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels May 23, 2024
@github-actions GitHub Actions
Copy link

Hi I'm an AI powered bot that finds similar issues based off the issue title.

Please view the issues below to see if they solve your problem, and if the issue describes your problem please consider closing this one and thumbs upping the other issue to help us prioritize it. Thank you!

Closed similar issues:

Note: You can give me feedback by thumbs upping or thumbs downing this comment.

@j4james
Copy link
Collaborator Author

j4james commented May 23, 2024

This looks like it regressed in 4fbcd65. I don't have time to investigate now, but if I remember correctly the GDI engine used to have some special case handling for the cursor when scrolling, so that might have something to do with this. The problem doesn't occur if the Atlas engine is used.

@lhecker lhecker mentioned this issue May 29, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue May 29, 2024
@lhecker
Cursor coordinates are viewport-relative (#17332)
0bd0eea 
The changeset is rather self-explanatory.
Some things in the rendering code are in
absolute and some things are in relative
coordinates. Cursor coordinates belong to
the latter. It's a bit confusing.

Closes #17310

## Validation Steps Performed
* Use the GDI text renderer
* Use cmd
* Press and hold Enter
* No more ghostly cursors ✅
@lhecker lhecker mentioned this issue Oct 16, 2024
Closed
@microsoft-github-policy-service microsoft-github-policy-service bot added the In-PR This issue has a related PR label Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
In-PR This issue has a related PR Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Cursor coordinates are viewport-relative microsoft/terminal
1 participant
@j4james