Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AtlasEngine: Fix ClearType being always enabled #12705

Merged
2 commits merged into from
Mar 17, 2022
Merged

AtlasEngine: Fix ClearType being always enabled #12705

2 commits merged into from
Mar 17, 2022

Conversation

lhecker
Copy link
Member

@lhecker lhecker commented Mar 16, 2022

HLSL uses 32-bit booleans, while C++ uses 8-bit ones aligned by 32-bit.
This meant that the shader was accessing uninitialized memory
forcing ClearType blending to be randomly enabled.

This regressed in commit 5964060.

PR Checklist

  • I work here
  • Tests added/passed

Validation Steps Performed

  • ClearType blending works ✅
  • Enabling transparent backgrounds forces grayscale blending ✅

@lhecker lhecker added Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-3 A description (P3) Area-AtlasEngine labels Mar 16, 2022
DHowett
DHowett approved these changes Mar 16, 2022
View reviewed changes
src/renderer/atlas/AtlasEngine.h Show resolved Hide resolved
@DHowett DHowett added the Needs-Second It's a PR that needs another sign-off label Mar 16, 2022
@DHowett DHowett added the AutoMerge Marked for automatic merge by the bot when requirements are met label Mar 17, 2022
@ghost
Copy link

ghost commented Mar 17, 2022

Hello @DHowett!

Because this pull request has the AutoMerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost ghost merged commit 830a422 into main Mar 17, 2022
@ghost ghost deleted the dev/lhecker/atlas-engine-power-draw-reduction-fixup branch March 17, 2022 19:45
@ghost
Copy link

ghost commented May 24, 2022

🎉Windows Terminal Preview v1.14.143 has been released which incorporates this pull request.:tada:

Handy links:

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zadjii-msft zadjii-msft zadjii-msft approved these changes

@DHowett DHowett DHowett approved these changes

@miniksa miniksa Awaiting requested review from miniksa

@carlos-zamora carlos-zamora Awaiting requested review from carlos-zamora

@PankajBhojwani PankajBhojwani Awaiting requested review from PankajBhojwani

Assignees
No one assigned
Labels
Area-AtlasEngine AutoMerge Marked for automatic merge by the bot when requirements are met Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Second It's a PR that needs another sign-off Priority-3 A description (P3)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lhecker @DHowett @zadjii-msft