Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for rich code navigation in GitHub, redux #12910

Merged
merged 9 commits into from
Apr 18, 2022
Merged

Add support for rich code navigation in GitHub, redux #12910

merged 9 commits into from
Apr 18, 2022

Conversation

zadjii-msft
Copy link
Member

This is exactly the same as #12855, save for one small difference:

diff --git a/build/pipelines/ci.yml b/build/pipelines/ci.yml
index e4e53e9b2..dc9040aeb 100644
--- a/build/pipelines/ci.yml
+++ b/build/pipelines/ci.yml
@@ -99,7 +99,6 @@ stages:
   - stage: CodeIndexer
     displayName: Github CodeNav Indexer
     dependsOn: [Build_x64]
-    condition: succeeded()
+    condition: and(succeeded(), not(eq(variables['Build.Reason'], 'PullRequest')))
     jobs:
       - template: ./templates/codenav-indexer.yml
-    condition: not(eq(variables['Build.Reason'], 'PullRequest'))

Because the first ones failed with
image

And that hosed the whole CI

@zadjii-msft zadjii-msft added Area-Build Issues pertaining to the build system, CI, infrastructure, meta Product-Meta The product is the management of the products. labels Apr 15, 2022
DHowett
DHowett approved these changes Apr 18, 2022
View reviewed changes
Copy link
Member

@DHowett DHowett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the bad signoff ;P

@DHowett DHowett merged commit f0d0831 into main Apr 18, 2022
@DHowett DHowett deleted the dev/migrie/ci/gh-codenav branch April 18, 2022 18:41
@ghost
Copy link

ghost commented May 24, 2022

🎉Windows Terminal Preview v1.14.143 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DHowett DHowett DHowett approved these changes

Assignees
No one assigned
Labels
Area-Build Issues pertaining to the build system, CI, infrastructure, meta Product-Meta The product is the management of the products.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zadjii-msft @DHowett