Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change TSFInputControl inputScope to AlphanumericHalfWidth #13028

Merged
1 commit merged into from
May 3, 2022

Conversation

YanceyChiew
Copy link
Contributor

@YanceyChiew YanceyChiew commented May 3, 2022

Modified the scope of input control, it used to be Text, now it is
AlphanumericHalfWidth. This input scope actually accepts any
characters, but English characters are preferred, and the soft keyboard
also displays English by default.

This should improve user friendliness for users using composition mode
input methods.

As a user who uses the composition mode input method, in applications
like windows terminal that should usually be input in English, it is
always required to manually switch to English mode by pressing Shift
before entering commands.

One keystroke is not a problem, but often for some reason there is no or
no successful switching, and additional more keystrokes are required to
clear the wrong input.

The input method that comes with windows will automatically switch to
English mode for a few programs such as conhost, but windows terminal is
not in this list.

This change should have no negative impact. Even if someone does tend to
use a shell oriented towards composition characters or non-alpha
letters, there should also were more users who in the same language are
more inclined to English characters shells, for example, cmd,
powershell, bash that comes with windows.

If there's any reason to have to keep the Text inputScope, maybe making
this setting customizable via settings.json would be a good idea, but
I don't see the need to do this, AlphanumericHalfWidth is perfect.

Closes #12731

Change TSFInputControl inputScope to AlphanumericHalfWidth.

This should improve user friendliness for users using composition mode input methods.
@ghost ghost added Area-i18n Internationalization issues (e.g.: non-US input handling doesn't work) Area-Input Related to input processing (key presses, mouse, etc.) Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal. labels May 3, 2022
Copy link
Member

@zadjii-msft zadjii-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You've got solid notes in #12731, so I'm cool with this. Thanks for taking the time to look into this! I know I sure learned something new 😄

@DHowett DHowett changed the title Change TSFInputControl inputScope to AlphanumericHalfWidth. Change TSFInputControl inputScope to AlphanumericHalfWidth May 3, 2022
@DHowett
Copy link
Member

DHowett commented May 3, 2022

Thank you!

@DHowett DHowett added the AutoMerge Marked for automatic merge by the bot when requirements are met label May 3, 2022
@ghost
Copy link

ghost commented May 3, 2022

Hello @DHowett!

Because this pull request has the AutoMerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 8 hours, a condition that will be fulfilled in about 1 hour 37 minutes. No worries though, I will be back when the time is right! 😉

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@DHowett
Copy link
Member

DHowett commented May 3, 2022

@msftbot merge this in 1 minute

@ghost
Copy link

ghost commented May 3, 2022

Hello @DHowett!

Because you've given me some instructions on how to help merge this pull request, I'll be modifying my merge approach. Here's how I understand your requirements for merging this pull request:

  • I won't merge this pull request until after the UTC date Tue, 03 May 2022 18:06:36 GMT, which is in 1 minute

If this doesn't seem right to you, you can tell me to cancel these instructions and use the auto-merge policy that has been configured for this repository. Try telling me "forget everything I just told you".

@ghost ghost merged commit 6e87e0b into microsoft:main May 3, 2022
@YanceyChiew YanceyChiew deleted the change_tsf_inputscope branch May 3, 2022 20:31
@ghost
Copy link

ghost commented May 24, 2022

🎉Windows Terminal Preview v1.14.143 has been released which incorporates this pull request.:tada:

Handy links:

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-i18n Internationalization issues (e.g.: non-US input handling doesn't work) Area-Input Related to input processing (key presses, mouse, etc.) AutoMerge Marked for automatic merge by the bot when requirements are met Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: Set IME input mode to English when a Windows Terminal window is opened
4 participants