Prevent ConPTY from de-snapping the terminal #13164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
Area-Windowing
DHowett
reviewed
May 24, 2022
| // window. There seem to be many issues with this so far, and the quickest | ||
| // route to mitigate them seems to be limiting the interaction here to | ||
| // allowing ConPTY to minimize the terminal only. This will still allow | ||
| // bodgy scripts to hide the Terminal via GetConsoleWindow(), but should |
There was a problem hiding this comment.
Can you use ShowWindow to minimize it, then restore it, and then use ShowWindow again in the same session? Or does it get into a torn state?
There was a problem hiding this comment.
Sure does! This is only preventing ShowWindow(GetConsoleWindow(), SW_SHOW) from going out to the terminal, the rest of the state still flows in to the pty window
lhecker
approved these changes
May 24, 2022
DHowett
reviewed
May 25, 2022
DHowett
pushed a commit
that referenced
this pull request
May 25, 2022
This is a big hammer to put out this fire. We're keeping the hiding around for now, cause we think that's likely the one that the internal tests use that we really care about here. If we need to bring this back, we can. * [x] Closes #13158 * [x] Closes #13162 * [x] Validated these both manually * [x] `[Native]::ShowWindow([Native]::GetConsoleWindow(), 6)` still works (cherry picked from commit 11b810e) Service-Card-Id: 82371517 Service-Version: 1.14
|
🎉 Handy links: |
This was referenced Jun 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a big hammer to put out this fire. We're keeping the hiding around for now, cause we think that's likely the one that the internal tests use that we really care about here. If we need to bring this back, we can.
[Native]::ShowWindow([Native]::GetConsoleWindow(), 6)still works