Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mis-aligned Navigationview footer and save buttons in the settings page #13282

Merged
2 commits merged into from Jun 13, 2022

Conversation

HO-COOH
Copy link
Contributor

@HO-COOH HO-COOH commented Jun 12, 2022

This improves the layout/appearance of the settings UI footer, by reducing
the height of the main content footer to match the navigation view footer.

Copy link
Member

@zadjii-msft zadjii-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DHowett let's get this in for the bug bash today

@lhecker
Copy link
Member

lhecker commented Jun 13, 2022

Original commit message:

Summary of the Pull Request

As title suggest

Detailed Description of the Pull Request / Additional comments

I made this
image

to this
image

Because it bugs me every time 😅

I searched for ways to get the actual size of the NavigationView footer items so it does not use the hard-coded property Height , but was not able to find one. Let me know if there is alternative ways.

@lhecker
Copy link
Member

lhecker commented Jun 13, 2022

I hope you don't mind, but I've edited your PR message. We don't usually commit GitHub image links into our main branch - the images might not always remain online after all. Since it's such a simple commit I've kept the message at a bare minimum.

@lhecker lhecker added the Area-Settings UI Anything specific to the SUI label Jun 13, 2022
@DHowett DHowett added the AutoMerge Marked for automatic merge by the bot when requirements are met label Jun 13, 2022
@ghost
Copy link

ghost commented Jun 13, 2022

Hello @DHowett!

Because this pull request has the AutoMerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost ghost merged commit d866908 into microsoft:main Jun 13, 2022
@ghost
Copy link

ghost commented Jul 6, 2022

🎉Windows Terminal Preview v1.15.186 has been released which incorporates this pull request.:tada:

Handy links:

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Settings UI Anything specific to the SUI AutoMerge Marked for automatic merge by the bot when requirements are met
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants