-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to XAML 2.7.3 #14123
Update to XAML 2.7.3 #14123
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure if there's any value in updating to 2.7.3, when we could also upgrade to 2.8. (I'm not a WinUI versioning expert though...)
I'd rather we keep the scratch on the same version as the main solution (i.e., 2.7.3). Was this tested locally? The scratch sln doesn't build in CI, so it'll need a manual validation |
This was indeed tested locally. |
And the prerelease version of it
2.8 is much riskier (new version and all!) and requires a WebView2 dependency... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@zadjii-msft yup, scratch builds and deploys just fine :)
For anybody that's interested, here's the XAML releases page
@msftbot merge this in 10 minutes |
Hello @carlos-zamora! Because you've given me some instructions on how to help merge this pull request, I'll be modifying my merge approach. Here's how I understand your requirements for merging this pull request:
If this doesn't seem right to you, you can tell me to cancel these instructions and use the auto-merge policy that has been configured for this repository. Try telling me "forget everything I just told you". |
This will let those projects build. I forgot to include them last time for some reason. See PR #14123
And the prerelease version of it (cherry picked from commit 11ad047) Service-Card-Id: 87207161 Service-Version: 1.16
And the prerelease version of it (cherry picked from commit 11ad047) Service-Card-Id: 87207160 Service-Version: 1.15
🎉 Handy links: |
🎉 Handy links: |
Hmm. This predates 1.15.2875.0, which was the first time that #14501 was reported, so this ain't it. |
And the prerelease version of it