Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't crash when turning on Voice Access #14534

Merged
1 commit merged into from
Dec 12, 2022
Merged

Don't crash when turning on Voice Access #14534

1 commit merged into from
Dec 12, 2022

Conversation

zadjii-msft
Copy link
Member

I should have checked the wparam.

Regressed in #14064.

Tested manually. No more crashy.

Closes #14504

@ghost ghost added Area-Windowing Window frame, quake mode, tearout Issue-Bug It either shouldn't be doing this or needs an investigation. Product-Terminal The new Windows Terminal. Severity-Blocking We won't ship a release like this! No-siree. Severity-Crash Crashes are real bad news. labels Dec 12, 2022
@carlos-zamora carlos-zamora added the Needs-Second It's a PR that needs another sign-off label Dec 12, 2022
@ghost ghost requested review from PankajBhojwani, DHowett and lhecker December 12, 2022 17:54
@DHowett
Copy link
Member

DHowett commented Dec 12, 2022

@msftbot merge this in 1 minute

@ghost ghost added the AutoMerge Marked for automatic merge by the bot when requirements are met label Dec 12, 2022
@ghost
Copy link

ghost commented Dec 12, 2022

Hello @DHowett!

Because you've given me some instructions on how to help merge this pull request, I'll be modifying my merge approach. Here's how I understand your requirements for merging this pull request:

  • I won't merge this pull request until after the UTC date Mon, 12 Dec 2022 19:23:15 GMT, which is in 1 minute

If this doesn't seem right to you, you can tell me to cancel these instructions and use the auto-merge policy that has been configured for this repository. Try telling me "forget everything I just told you".

@ghost ghost merged commit 58ce22d into main Dec 12, 2022
@ghost ghost deleted the dev/migrie/b/14504-voice-access-crash branch December 12, 2022 19:25
@ghost
Copy link

ghost commented Jan 24, 2023

🎉Windows Terminal Preview v1.17.1023 has been released which incorporates this pull request.:tada:

Handy links:

@ghost ghost mentioned this pull request Jan 24, 2023
Closed
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlos-zamora carlos-zamora carlos-zamora approved these changes

@DHowett DHowett DHowett approved these changes

@PankajBhojwani PankajBhojwani Awaiting requested review from PankajBhojwani

@lhecker lhecker Awaiting requested review from lhecker

Assignees
No one assigned
Labels
Area-Windowing Window frame, quake mode, tearout AutoMerge Marked for automatic merge by the bot when requirements are met Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Second It's a PR that needs another sign-off Product-Terminal The new Windows Terminal. Severity-Blocking We won't ship a release like this! No-siree. Severity-Crash Crashes are real bad news. zBugBash-Consider
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[1.17] Crash with Voice Access launch
3 participants
@zadjii-msft @DHowett @carlos-zamora