Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a crash when the theme doesn't have a window #14540

Merged
1 commit merged into from
Dec 13, 2022

Conversation

zadjii-msft
Copy link
Member

From team sync today.

@zadjii-msft zadjii-msft added the Area-Theming Anything related to the theming of elements of the window label Dec 12, 2022
Copy link
Member

@DHowett DHowett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ha! thanks

@DHowett
Copy link
Member

DHowett commented Dec 12, 2022

@msftbot merge this in 1 minute

@ghost ghost added the AutoMerge Marked for automatic merge by the bot when requirements are met label Dec 12, 2022
@ghost
Copy link

ghost commented Dec 12, 2022

Hello @DHowett!

Because you've given me some instructions on how to help merge this pull request, I'll be modifying my merge approach. Here's how I understand your requirements for merging this pull request:

  • I won't merge this pull request until after the UTC date Mon, 12 Dec 2022 22:39:02 GMT, which is in 1 minute

If this doesn't seem right to you, you can tell me to cancel these instructions and use the auto-merge policy that has been configured for this repository. Try telling me "forget everything I just told you".

@zadjii-msft zadjii-msft added Needs-Second It's a PR that needs another sign-off zBugBash-Consider labels Dec 12, 2022
@ghost ghost merged commit 6972863 into main Dec 13, 2022
@ghost ghost deleted the dev/migrie/b/window-mica-oops branch December 13, 2022 18:50
@ghost
Copy link

ghost commented Jan 24, 2023

🎉Windows Terminal Preview v1.17.1023 has been released which incorporates this pull request.:tada:

Handy links:

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Theming Anything related to the theming of elements of the window AutoMerge Marked for automatic merge by the bot when requirements are met Needs-Second It's a PR that needs another sign-off zBugBash-Consider
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants