Make sure focused tab text color accounts for alpha #14643
Conversation
ghost
added
Area-User Interface
|
|
ghost
requested review from
| @@ -388,6 +379,25 @@ namespace winrt::TerminalApp::implementation | |||
| subtleFillColorTertiaryBrush.Color(subtleFillColorTertiary); | |||
| } | |||
|
|
|||
| // The tab font should be based on the evaluated appearance of the tab color layered on tab row. | |||
| const auto layeredTabColor = til::color{ color }.layer_over(_tabRowColor); | |||
There was a problem hiding this comment.
What does this do if the _tabRowColor is fully transparent?
There was a problem hiding this comment.
oooooh good question
There was a problem hiding this comment.
I'd guess that it would treat it as black, cause alpha=0 * (r,g,b) => (0,0,0)
There was a problem hiding this comment.
Yep, we treat it as 0,0,0 and end up with white text.
|
Do you have an inkling as to whether this reproduces on 1.16? |
I'd bet it does |
zadjii-msft
added
the
AutoMerge
|
Hello @zadjii-msft! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
Basically what it says on the tin. For transparent tabs, we should layer on to the tab row to evaluate what the actual color of the tab will be. We did this for deselected tabs, but not for selected ones. Gif below. Closes #14561 (cherry picked from commit 4c7879b) Service-Card-Id: 87567529 Service-Version: 1.16
|
🎉 Handy links: |
ghost
mentioned this pull request
|
🎉 Handy links: |
Basically what it says on the tin. For transparent tabs, we should layer on to the tab row to evaluate what the actual color of the tab will be. We did this for deselected tabs, but not for selected ones.
Gif below.
Closes #14561