Fix an issue where JsonUtils produces a bad error message #14668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CascadiaSettings relies on getting a JsonUtils::DeserializationException from the various JSON Utility functions, and then formatting that into an error message. Well, DeserializationException tries to include an object representation in its what() message . . . and generates an exception trying to do so. CascadiaSettings never gets the DeserializationException, and displays a weird message. Fixes #14373
ghost
added
Area-Settings
|
Before: bad After: |
zadjii-msft
approved these changes
Jan 12, 2023
ghost
requested review from
|
@msftbot merge this in 7 minutes |
ghost
added
the
AutoMerge
|
Hello @DHowett! Because you've given me some instructions on how to help merge this pull request, I'll be modifying my merge approach. Here's how I understand your requirements for merging this pull request:
If this doesn't seem right to you, you can tell me to cancel these instructions and use the auto-merge policy that has been configured for this repository. Try telling me "forget everything I just told you". |
carlos-zamora
approved these changes
Jan 13, 2023
DHowett
added a commit
that referenced
this pull request
Jan 13, 2023
CascadiaSettings relies on getting a JsonUtils::DeserializationException from the various JSON Utility functions, and then formatting that into an error message. Well, DeserializationException tries to include an object representation in its what() message . . . and generates an exception trying to do so. CascadiaSettings never gets the DeserializationException, and displays a weird message. It's safe to remove the stringification in DeserializationException because CascadiaSettings was never using it (_and_ because CascadiaSettings was using an even better version of the same logic.) Fixes #14373 (cherry picked from commit 239b4d1) Service-Card-Id: 87568498 Service-Version: 1.16
|
🎉 Handy links: |
ghost
mentioned this pull request
|
🎉 Handy links: |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CascadiaSettings relies on getting a JsonUtils::DeserializationException
from the various JSON Utility functions, and then formatting that into
an error message. Well, DeserializationException tries to include an
object representation in its what() message . . . and generates an
exception trying to do so. CascadiaSettings never gets the
DeserializationException, and displays a weird message.
It's safe to remove the stringification in DeserializationException
because CascadiaSettings was never using it (and because
CascadiaSettings was using an even better version of the same logic.)
Fixes #14373