Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Defer package updates while the Terminal is running #16250

Merged
merged 1 commit into from
Nov 7, 2023

Conversation

zadjii-msft
Copy link
Member

Adds

    <uap17:UpdateWhileInUse>defer</uap17:UpdateWhileInUse>

To our Package.Properties for all our packages. This was added in the September 2023 OS release of Windows 11.

Apparently, this just works now? I did update VS, but I don't think that updated the SDK. I have no idea how it updated the manifest definitions.

Closes #3915
Closes #6726

Adds

```xml
    <uap17:UpdateWhileInUse>defer</uap17:UpdateWhileInUse>
```

To our `Package.Properties` for all our packages. This was added in the September 2023 OS release of Windows 11.

Apparently, this just works now? I did update VS, but I don't _think_ that
updated the SDK. I have no idea how it updated the manifest definitions.

Closes #3915
Closes #6726
@microsoft-github-policy-service microsoft-github-policy-service bot added the Product-Terminal The new Windows Terminal. label Nov 1, 2023
@DHowett
Copy link
Member

DHowett commented Nov 6, 2023

Servicing only to preview.

@lhecker lhecker merged commit 077d63e into main Nov 7, 2023
15 of 17 checks passed
@lhecker lhecker deleted the dev/migrie/f/defer-updates branch November 7, 2023 20:35
@sba923
Copy link

sba923 commented Nov 7, 2023

So this fix doesn't apply to Windows 10?

@tovine
Copy link

tovine commented Nov 7, 2023

I was about to ask the same - not everyone can use Windows 11 yet (either due to company policies or "old" hardware - i.e. anything older than Coffee Lake or Zen+).

Since my original issue #3915 was reported on Windows 10 I guess this means it's either coming there as well, or that issue has been incorrectly marked as fixed?

radu-cernatescu pushed a commit to radu-cernatescu/terminal that referenced this pull request Nov 8, 2023
Adds
```xml
<uap17:UpdateWhileInUse>defer</uap17:UpdateWhileInUse>
```
to our `Package.Properties` for all our packages.
This was added in the September 2023 OS release of Windows 11.

Apparently, this just works now? I did update VS,
but I don't _think_ that updated the SDK.
I have no idea how it updated the manifest definitions.

Closes microsoft#3915
Closes microsoft#6726
DHowett pushed a commit that referenced this pull request Nov 13, 2023
Adds
```xml
<uap17:UpdateWhileInUse>defer</uap17:UpdateWhileInUse>
```
to our `Package.Properties` for all our packages.
This was added in the September 2023 OS release of Windows 11.

Apparently, this just works now? I did update VS,
but I don't _think_ that updated the SDK.
I have no idea how it updated the manifest definitions.

Closes #3915
Closes #6726

(cherry picked from commit 077d63e)
Service-Card-Id: 91033136
Service-Version: 1.19
@zadjii-msft
Copy link
Member Author

As noted in #17385: Looks like Windows 11 builds 25399+ will be the first ones that actually have support for this. So Terminal is more than ready for it, but we need to wait for that to roll out broadly.

Our friends on the Store team also investigated backporting to earlier Windows versions, but that wasn't a possibility at this time. Alas, at least it's coming SoonTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Product-Terminal The new Windows Terminal.
Projects
Development

Successfully merging this pull request may close these issues.

Please provide a way to delay updates Terminal windows are closed whenever updated from the store
5 participants