Fix race conditions in UiaTextRangeBase #17257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lhecker
added
Issue-Bug
lhecker
force-pushed
the
dev/lhecker/uia-race
branch
2 times, most recently
from
27c4853
to
3256dda
Compare
lhecker
force-pushed
the
dev/lhecker/uia-race
branch
from
3256dda
to
e891831
Compare
zadjii-msft
approved these changes
May 13, 2024
DHowett
approved these changes
May 13, 2024
| @@ -148,9 +162,6 @@ til::point UiaTextRangeBase::GetEndpoint(TextPatternRangeEndpoint endpoint) cons | |||
| // - true if range is degenerate, false otherwise. | |||
| bool UiaTextRangeBase::SetEndpoint(TextPatternRangeEndpoint endpoint, const til::point val) noexcept | |||
| { | |||
| // GH#6402: Get the actual buffer size here, instead of the one | |||
There was a problem hiding this comment.
Is this todo no longer relevant?
|
Added to 1.20 as well |
DHowett
pushed a commit
that referenced
this pull request
May 13, 2024
We need to lock the buffer when getting the viewport/cursor position. This caused the UIA overlay to randomly fail to update. ## Validation Steps Performed * Open a cmd tab and hold any key immediately * Repeat until you're somewhat confident it's gone ✅ (cherry picked from commit e1b102a) Service-Card-Id: 92546851 Service-Version: 1.20
DHowett
pushed a commit
that referenced
this pull request
May 13, 2024
We need to lock the buffer when getting the viewport/cursor position. This caused the UIA overlay to randomly fail to update. ## Validation Steps Performed * Open a cmd tab and hold any key immediately * Repeat until you're somewhat confident it's gone ✅ (cherry picked from commit e1b102a) Service-Card-Id: 92546408 Service-Version: 1.21
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to lock the buffer when getting the viewport/cursor position.
This caused the UIA overlay to randomly fail to update.
Validation Steps Performed