Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase left padding around tabs #3513

Merged
merged 3 commits into from
Nov 12, 2019
Merged

Increase left padding around tabs #3513

merged 3 commits into from
Nov 12, 2019

Conversation

cinnamon-msft
Copy link
Contributor

@cinnamon-msft cinnamon-msft commented Nov 11, 2019

Summary of the Pull Request

Reset the padding to default around the tabs.

References

PR Checklist

  • Closes Increase padding around tabs #3370
  • CLA signed. If not, go over here and sign the CLA
  • Tests added/passed
  • Requires documentation to be updated
  • I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx

Detailed Description of the Pull Request / Additional comments

New padding

image

Original padding

image

Validation Steps Performed

Copy link
Contributor

@DHowett-MSFT DHowett-MSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor dispreference. Users seem to be asking for less padding, but I think there’s a compromise to be had between 0 and “original.”

@ghost ghost added the Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something label Nov 11, 2019
@cinnamon-msft
Copy link
Contributor Author

Tweaking now :)

@ghost ghost removed the Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something label Nov 11, 2019
@ZhaoMJ
Copy link
Contributor

ZhaoMJ commented Nov 11, 2019

From the screenshot, the X in the tab and the + and v are no longer aligned?

@zadjii-msft
Copy link
Member

re: user preference on this - I think this is one of those discussions well suited for #3327. I personally want no padding at all, tabs flush to the top, always. However, I think that this is sane default to have, and looks consistent with Edgium.

#3510 is discussing reducing the padding, but specifically with regards to when the window is maximized.

Are we concerned that the increased space on the top of tabs, left of tabs will lead to more requests/complaints about being unable to drag there?

@cinnamon-msft
Copy link
Contributor Author

I've just updated it to only have left padding. This could be a nice compromise and it doesn't add too much space where people could try to drag.

Additionally, this fixes the misaligned dropdown buttons.

Copy link
Member

@carlos-zamora carlos-zamora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure

Copy link
Member

@zadjii-msft zadjii-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can dig it

@DHowett-MSFT DHowett-MSFT changed the title Increase padding around tabs Increase left padding around tabs Nov 12, 2019
@DHowett-MSFT DHowett-MSFT merged commit d2ca3c1 into master Nov 12, 2019
@DHowett-MSFT DHowett-MSFT deleted the cinnamon/tab-padding branch November 12, 2019 19:19
@zadjii-msft zadjii-msft added Area-User Interface Issues pertaining to the user interface of the Console or Terminal Product-Terminal The new Windows Terminal. labels Nov 12, 2019
@ghost
Copy link

ghost commented Nov 26, 2019

🎉Windows Terminal Preview v0.7.3291.0 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-User Interface Issues pertaining to the user interface of the Console or Terminal Product-Terminal The new Windows Terminal.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Increase padding around tabs
5 participants