-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Increase left padding around tabs #3513
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor dispreference. Users seem to be asking for less padding, but I think there’s a compromise to be had between 0 and “original.”
Tweaking now :) |
From the screenshot, the X in the tab and the + and v are no longer aligned? |
re: user preference on this - I think this is one of those discussions well suited for #3327. I personally want no padding at all, tabs flush to the top, always. However, I think that this is sane default to have, and looks consistent with Edgium. #3510 is discussing reducing the padding, but specifically with regards to when the window is maximized. Are we concerned that the increased space on the top of tabs, left of tabs will lead to more requests/complaints about being unable to drag there? |
I've just updated it to only have left padding. This could be a nice compromise and it doesn't add too much space where people could try to drag. Additionally, this fixes the misaligned dropdown buttons. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can dig it
🎉 Handy links: |
Summary of the Pull Request
Reset the padding to default around the tabs.
References
PR Checklist
Detailed Description of the Pull Request / Additional comments
New padding
Original padding
Validation Steps Performed