Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose app id of the automatic generated SP for AzureRM service endpoint #241

Closed
wants to merge 1 commit into from

Conversation

mispencer
Copy link

All Submissions:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • My code follows the code style of this project.
  • I ran lint checks locally prior to submission.
  • Have you checked to ensure there aren't other open PRs for the same update/change?

What about the current behavior has changed?

Expose the id of the automatic generated service principal for an AzureRM service endpoint. This is necessary to grant other roles or other such changes to the generated SP within the terraform module.

Does this introduce a change to go.mod, go.sum or vendor/?

  • Yes
  • No

Does this introduce a breaking change?

  • Yes
  • No

@ghost
Copy link

ghost commented Dec 1, 2020

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

❌ mispencer sign now
You have signed the CLA already but the status is still pending? Let us recheck it.

@mispencer
Copy link
Author

I am unsure on how to write tests for this. Any help would be appreciated with this.

@xuzhang3
Copy link
Collaborator

@mispencer

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

❌ mispencer sign now
You have signed the CLA already but the status is still pending? Let us recheck it.

@mispencer You need sign the Contributor License Agreement.
Current service endpoint commons.go has a bug. After the creation finished, create function won't invoke the read function to retrieve the real resource but use the data generated in the create function, the result will be that the serviceprincipalid will always be an empty string. You can wait for my bug fix PR or you can fix it.

@xuzhang3
Copy link
Collaborator

Hi @mispencer Please sign the Contributor License Agreement then I can help merge you PR.
CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

❌ mispencer sign now
You have signed the CLA already but the status is still pending? Let us recheck it.

@mispencer
Copy link
Author

I am working on getting approved to sign.

@xuzhang3
Copy link
Collaborator

Hi @mispencer I'm going close this PR, this feature has been implemented in another PR #241

@xuzhang3 xuzhang3 closed this Mar 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants